search

Rishabh-malhotraa / caucus

Realtime Collaborate Editor with Embedded Compiler
https://caucus.rishabhmalhotra.in/
MIT License
297 stars 70 forks source link

solved "Refactor Code for roomID extractions" issue #32

Closed MarufSharifi closed 3 years ago

MarufSharifi commented 3 years ago

have done this tasks

1 created a context to store the RoomID by the name of RoomIDContext. 2 created a type for RoomIDContext in types file by the name of RoomIDContextTypes. 3 created a custom hook by the name of useRoomID to make consuming RoomIDContext easy. 4 at first used the useRoomID in this directory "src/pages/Room/Room.tsx" to set RoomID to RoomIDContext. 5_ read the RoomID from RoomIDContext instead of getting the RoomID from useParams.

closes #22

Rishabh-malhotraa commented 3 years ago

@MarufSharifi Thank you so much for the PR; this looks great. I'll review your PR in a couple of days, from my initial glance over the changes, everything looks fine 🙌🏻

MarufSharifi commented 3 years ago

Hey @Rishabh-malhotraa, I am interested to work on this project. I have reviewed all the codes of the project, this is a really good project in my tech stack, I know typescript, javascript, React and React native, could you please help to implement the remaining features of this project?

Rishabh-malhotraa commented 3 years ago

Hey @MarufSharifi, we can connect on discord rishabh.malhotra#4193, and we can discuss the features I plan to implement. You can also suggest anything if you are interested.

Rishabh-malhotraa commented 3 years ago

@all-contributors please add @MarufSharifi for infrastructure and code

allcontributors[bot] commented 3 years ago

@Rishabh-malhotraa

I've put up a pull request to add @MarufSharifi! :tada:

Rishabh-malhotraa commented 3 years ago

LGTM thank you!