Rishabh-malhotraa / caucus

Realtime Collaborate Editor with Embedded Compiler
https://caucus.rishabhmalhotra.in/
MIT License
295 stars 70 forks source link

cses problem url support added #55

Open starkkumarkk1611 opened 2 years ago

starkkumarkk1611 commented 2 years ago

I have solved issue #52 Please review my code and merge it. If any Improvement is needed please suggest and guide me.

thanks, I would like to work on more issues like this.

Rishabh-malhotraa commented 2 years ago

can you allow edits from maintainer

https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

starkkumarkk1611 commented 2 years ago

can you allow edits from maintainer

https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

done ...

Rishabh-malhotraa commented 2 years ago

@MarufSharifi do you mind reviewing this PR and seeing if the changes make sense?

starkkumarkk1611 commented 2 years ago

@Rishabh-malhotraa sorry sir for being late, I have made the requested changes. I think sir now you can merge it.

MarufSharifi commented 2 years ago

Please consider a new candition in the CodeForces.tsx for cses.fi as well.

<div> {hostname === "codeforces.com" ? ( <div className={"codeforces"} ref={MathRef}> {parse(htmlString)} </div> ) : ( <div className={"atcoder"} ref={MathRef}> {parse(htmlString)} </div> )} <Divider /> </div>

please consider this changes as well

starkkumarkk1611 commented 2 years ago

Please consider a new candition in the CodeForces.tsx for cses.fi as well. <div> {hostname === "codeforces.com" ? ( <div className={"codeforces"} ref={MathRef}> {parse(htmlString)} </div> ) : ( <div className={"atcoder"} ref={MathRef}> {parse(htmlString)} </div> )} <Divider /> </div>

please consider these changes as well

thanks, just now I am doing sir