search

Rishabh-malhotraa / caucus

Realtime Collaborate Editor with Embedded Compiler
https://caucus.rishabhmalhotra.in/
MIT License
295 stars 70 forks source link

Add pre commit hook with husky #66

Open Rishabh-malhotraa opened 2 years ago

Rishabh-malhotraa commented 2 years ago

I see inconsistency with formating in pull requests; to prevent this, it is better to configure a pre-commit hook to standardize formatting.

Resources

https://www.youtube.com/watch?v=oWty0Nw1ydk

https://khalilstemmler.com/blogs/tooling/enforcing-husky-precommit-hooks/

pavankalyan-codes commented 2 years ago

Hey I can work on this. Could you pls assign this to me.

pavankalyan-codes commented 2 years ago

Hey! raised PR for this #69 . Pls review and merge if everything looks fine on review.

Rishabh-malhotraa commented 2 years ago

Thanks for the PR @pavankalyan-codes , I'll review the changes in the coming days!

hadviad0x15 commented 2 years ago

Hi sir, greeting of the day, I have worked in few react based projects. I have basic idea of how thing work around in react. I am taking part in hacktober fest 2021 and I found this issue interesting and think i can contribute to this. According to my understanding after reading the blog you suggest above I learn that here I have to make changes in package.json file and add a husky hook with have a pre commit, pre push also i need to make changes in scripts under package.json and add a prettier and eslint. This changes are need so when any developer try to save and commit it will automatically run prettier for formatting and eslint for coding convection. If i follow correctly please assign me this issue. @Rishabh-malhotraa