search

RishabhJain0721 / Brain-Box

Brain-Box is a web application that allows students to organize and manage their study materials, including subjects, chapters, notes, and video links.
https://brain-box-dun.vercel.app
27 stars 19 forks source link

Add full responsiveness #2

Closed Muz4mmil closed 8 months ago

Muz4mmil commented 8 months ago

Resolves #1 Closes #1 Hey @RishabhJain0721 , I am doing a PR directly to master branch. Kindly check and Merge it under hacktoberfest and hacktoberfest-accepted tags and labels.

vercel[bot] commented 8 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @RishabhJain0721 on Vercel.

@RishabhJain0721 first needs to authorize it.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
brain-box ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 7:50am
Muz4mmil commented 8 months ago

Screenshot_20231029-132508_Chrome

@RishabhJain0721 Hello bro, As soon as you merged the PR, it shows not accepted in hacktoberfest page. Do you have any idea?? Also, can you try adding hacktoberfest-accepted label too... It was a tough work taking that subject pane to nav menu, I want this issue to get counted

RishabhJain0721 commented 8 months ago

I have merged your PR. A tip : Don't push any code having some API key directly. Use a .env file to manage it.

Muz4mmil commented 8 months ago

I have merged your PR. A tip : Don't push any code having some API key directly. Use a .env file to manage it.

Yeah thanks for merging. But I just forked your repo, cloned, made changes and created PR. I didn't touched any api or your Firebase config

RishabhJain0721 commented 8 months ago

@Muz4mmil Hello bro I am sorry you are facing this. I have added all required labels, don't know why it's happening.

RishabhJain0721 commented 8 months ago

I have merged your PR. A tip : Don't push any code having some API key directly. Use a .env file to manage it.

Yeah thanks for merging. But I just forked your repo, cloned, made changes and created PR. I didn't touched any api or your Firebase config

It was in your commit history so I assume it was done by some mistake. Alright now I have changed it.

Muz4mmil commented 8 months ago

@Muz4mmil Hello bro I am sorry you are facing this. I have added all required labels, don't know why it's happening.

Uhh okay no issues, By the way how's the app now? Do you want any changes?

Also note that, it is not realtime responsive, I mean if you want to check the responsiveness, you have to reload the page every time you change the screen ( that's not an issue I guess )

RishabhJain0721 commented 8 months ago

@Muz4mmil Hello bro I am sorry you are facing this. I have added all required labels, don't know why it's happening.

Uhh okay no issues, By the way how's the app now? Do you want any changes?

Also note that, it is not realtime responsive, I mean if you want to check the responsiveness, you have to reload the page every time you change the screen ( that's not an issue I guess )

It's definitely looking better then before. That sidebar is really nice. I don't want any changes as of now. That's not a big issue, can be ignored.

Thanks for contributing. 👍🏻

Muz4mmil commented 8 months ago

Hey @RishabhJain0721 Now the PR is getting counted, I don't know how 😂. Thanks for supporting and sorry for inconvenience, I am new to Open source and still learning how stuff works.