search

RishabhRD / nvim-lsputils

Better defaults for nvim-lsp actions
456 stars 19 forks source link

Moving down menu highlights options #14

Closed jacksonludwig closed 4 years ago

jacksonludwig commented 4 years ago

Hello, with the last couple updates to this plugin, I noticed that when navigating the code action menu, options that I scroll over stay highlighted instead of just the current action.

For example, this is what it looks like when I trigger a code action and press j three times: image

I am on the latest nvim nightly, arch, and using the latest version of this plugin.

Thanks for your work!

RishabhRD commented 4 years ago

Are you experiencing the same with references, symbols, etc?

jacksonludwig commented 4 years ago

No actually, it's just the popups from code action

RishabhRD commented 4 years ago

I was not able to replicate the behavior. However, I removed some suspicious code from popfix. Can you try 'issue14' branch of popfix? I just pushed it recently just for check. It may or may not work because I was not able to reproduce the bug.

jacksonludwig commented 4 years ago

Yep, using the issue14 branch fixes the issue, thanks for the quick fix!

RishabhRD commented 4 years ago

OK! I would merge that in master just after completing few checks. :smiley:

RishabhRD commented 4 years ago

popfix issue14 branch merged to master! closing the issue then. Thanks for reporting :smile: