search

RishabhRD / nvim-lsputils

Better defaults for nvim-lsp actions
456 stars 19 forks source link

`codeAction` tries to spawn a popfix `floating_win` with negative height #37

Closed hood closed 3 years ago

hood commented 3 years ago

I have the following override in place

vim.lsp.handlers['textDocument/codeAction'] = require'lsputil.codeAction'.code_action_handler

And, since yesterday, whenever I try to do

lua vim.lsp.buf.code_action()

I get the following error:

Error executing vim.schedule lua callback: .../.config/nvim/plugged/popfix/lua/popfix/floatin_win.lua:37: 'height' key must be a positive Integer
xanderio commented 3 years ago

Properly related to #30

RishabhRD commented 3 years ago

https://github.com/neovim/neovim/pull/15504 was merged yesterday that changed lsp-handler-spec. Updated the handler-specs in nvim-lsputils to match the same.

xanderio commented 3 years ago

Did you possible forget to push this?

RishabhRD commented 3 years ago

@xanderio lol yeah I fogot to push :joy: I pushed it now

hood commented 3 years ago

Thanks.