search

RishabhRD / popfix

Neovim lua API for highly extensible popup window
83 stars 3 forks source link

always enter prompt popup in insert mode #22

Closed hood closed 2 years ago

hood commented 2 years ago

Currently prompt type popups are entered in normal mode if user sets init_text to a non-null value. This, IMHO, is not good UX, as it changes behaviour unexpectedly, plus I've never seen cases of usage of normal mode in prompt popus in the wild. This PR fixes that and closes #20.

hood commented 2 years ago

@RishabhRD Super sorry for bothering you again, but this PR would allow me to fix an issue and move forward with my popui.nvim extension. Also, if you're too busy in this timeframe to maintain the repo, I offer myself to maintain it until you find some spare time to come back and get your hands back on it!

RishabhRD commented 2 years ago

No problem... I didnt test it... I was just testing it last night

RishabhRD commented 2 years ago

Its working great for me....

RishabhRD commented 2 years ago

LGTM so merging it

RishabhRD commented 2 years ago

@RishabhRD Super sorry for bothering you again, but this PR would allow me to fix an issue and move forward with my popui.nvim extension. Also, if you're too busy in this timeframe to maintain the repo, I offer myself to maintain it until you find some spare time to come back and get your hands back on it!

Yeah I would add you as the maintainer today.... Thanks for the contributions. It would be so helpful to make the plugin development active.

RishabhRD commented 2 years ago

I have added you as the collaborator.... Feel free to make any changes. Even breaking changes if that improves user experience or code quality. And again a super thanks for it.