search

RishabhRD / popfix

Neovim lua API for highly extensible popup window
83 stars 3 forks source link

[WIP] git submodule for fzy-native #7

Closed RishabhRD closed 3 years ago

RishabhRD commented 3 years ago

As @ruifm mentioned in #5, fzy-native sorter can be used as a submodule. It will not only help in updating the modules easily, it will also give proper credits to authors.

This pull request would also remove the fzy-native hard dependency.

Credits: @ruifm

RishabhRD commented 3 years ago

@ruifm Yeah! This was the very initial commit just to make sure hard dependency of fzy-lua-native is not there now. :sweat_smile:

I would just push another commit in a few minutes. That commit should have the required files. Once done we can test it out.

RishabhRD commented 3 years ago

@ruifm I have added all necessary files that are needed to make this work. I also added a script named install_fzy_native_sorter that is just a wrapper around git commands and make command. It would make it easier to install I guess.

If native sorter is not installed and anyone tries to use it, it prints a warning message and fallbacks to default sorter.

I tried it for some scenarios and I feel it is complete enough. What do you say? Do you feel is there something missing?

RishabhRD commented 3 years ago

@ruifm I feel we can merge it. The Makefile and readme are changed as your suggestion. Thanks for such great help. It would never be possible without your valuable suggestions.

This pull request needs your last approval to merge. :smiley_cat:

RishabhRD commented 3 years ago

@ruifm I don't know, you didn't reply for approval. I hope you are doing well and not in any trouble.

I am merging the pull request as it was a major issue of stability.

If you feel something is missing please comment or make an issue.

Thanks for such a great help! :smiley: