RishavOsaurus / NepalMoutainsAPI

Simple Web Scrapping done to create an API
MIT License
2 stars 5 forks source link

Add Heights endpoints #3

Open RishavOsaurus opened 1 week ago

RishavOsaurus commented 1 week ago

Make search like search?height=8848.68

GET /api/v1/search?height_gt=1230.4&height_lt=4000 GET /api/v1/search?height_gt=1230.4 GET /api/v1/search?height_st=1230.4

Indrajeet-S commented 1 week ago

Hey, I would like to add this heights endpoint feature! Could you assign this issue to me?

RishavOsaurus commented 1 week ago

Hi I have assigned it to you @Indrajeet-S

Indrajeet-S commented 1 week ago

Thanks but I can't see in assignees nvm I will start working on this issue!

RishavOsaurus commented 1 week ago

My bad! Just assigned now

shinigami-777 commented 1 week ago

@RishavOsaurus Can I work on this too?

RishavOsaurus commented 1 week ago

@RishavOsaurus Can I work on this too?

yes you can but better you two guys coooperate and do work distribution so that you dont duplicate the work already done @shinigami-777

shinigami-777 commented 1 week ago

@RishavOsaurus Can you review this PR. I have tested it locally with the added search parameters.