search

Rishikant181 / Rettiwt-API

A CLI tool and an API for fetching data from Twitter for free!
https://rishikant181.github.io/Rettiwt-API/
MIT License
305 stars 31 forks source link

Add request timeout #422

Closed omarcinkonis closed 5 months ago

omarcinkonis commented 5 months ago

Renamed Http enum to avoid case mismatch warning.

I noticed that errors were internal. I recommend making them public. Right now, it's impossible to extend errors, define them as return types, etc. in project where the package is used.

It might be a good idea to make everything public. Is there any benefit to having internal classes?

Rishikant181 commented 5 months ago

Is there any benefit to having internal classes? Honestly, no :P. I just exported what I thought will be used by a consumer of the library.

It might be a good idea to make everything public That's what I've been mulling over too for quite some time. Will surely make everything accessible.

I'll checkout an merge the PR in the morning (it's night here now).

Thanks for the contribution!