Rishit02 / pe

0 stars 0 forks source link

Missing element in view 3 sequence diagram #35

Open Rishit02 opened 2 months ago

Rishit02 commented 2 months ago

image.png

On the arrow between InternHubParser and :ViewCommandParser, there is no function call that can be seen, which may be confusing for the developer as they are unsure which function is used at that point.

soc-se-bot commented 2 months ago

Team's Response

Dear tester,

we want to thank you for your feedback

We intentionally chose hide implicit object creation, InternHubParser is calling the constructor of ViewCommandParser in the switch statement. The parsing of arguments (parse(arguments)) will be handled internally within the ViewCommandParser constructor.

Therefore, we intentionally chose to not represent it explicitly on the sequence diagram unless there was any specific method calls or interactions between these objects that we want to illustrate.

For all our 6 sequence diagrams, we decided to hide/explicitly show the function calls for object creations as shown in this bug report. Perhaps in the future, we can be more explicit to allow developers to understand what function is being executed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: "(b) Multiple buggy behaviors that are actually caused by the same defect and cannot be fixed independently (i.e., fixing one fixes the others automatically)."

Fixing the filter command sequence diagram does not fix the view command sequence diagram or any other diagram automatically.

AND this is not the same bug as the others.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/Rishit02/pe/main/files/5f5684e0-75db-487e-bca3-153422536452.png) Function names are not optional parameters as seen from above, it is necessary to include them as they form valid components of sequence diagrams. The developer can be confused as suddenly the string "filter" is missing from the command inputted from the user as it is passed between objects. Thus, I believe it is important to include object creation steps in between the objects.