RisingOSS-devices / official

RisingOS Code of Conducts
3 stars 4 forks source link

New maintainer For POCO F1 #10

Closed Finnaib closed 1 year ago

Finnaib commented 1 year ago

Device you want to apply for

Beryllium (POCO F1)

Device tree sources

https://github.com/Finnaib/device_xiaomi_beryllium.git
https://github.com/Finnaib/device_xiaomi_sdm845-common.git
https://github.com/Finnaib/kernel_xiaomi_sdm845.git
https://github.com/Finnaib/vendor_xiaomi.git

Link to the platform where you have released your unofficial build

https://t.me/finn_projects
https://t.me/finn_projects_support

Other ROM's you maintain officially or unofficially

3

Bugs on unofficial build

None

How long have you been building for?

10 Months

SELinux status?

Enforcing

Are you using a prebuilt kernel? If yes, why?

No.

Contact

Telegram username

@Finnaib
Finnaib commented 1 year ago

@manidweep

athizz2005 commented 1 year ago

Which all official roms u have ?

Finnaib commented 1 year ago

Currently all unofficial roms i have bliss and skylineui and droidxui Maybe I will drop bliss

On Sat, Aug 19, 2023, 10:22 PM JodOrWot @.***> wrote:

Which all official roms u have ?

— Reply to this email directly, view it on GitHub https://github.com/RisingOSS-devices/official/issues/10#issuecomment-1685043615, or unsubscribe https://github.com/notifications/unsubscribe-auth/A276J6ADYTLKTRXA3S2JFCTXWDVM5ANCNFSM6AAAAAA3WVNJC4 . You are receiving this because you authored the thread.Message ID: @.***>

athizz2005 commented 1 year ago

link for all of those released in global grp of ur device pls

Finnaib commented 1 year ago

link for all of those released in global grp of ur device pls

Ok https://t.me/PocoPhoneGlobalUpdates/7523 https://t.me/PocoPhoneGlobalUpdates/7437 https://t.me/PocoPhoneGlobalUpdates/7370(i was previously officially co -maintainer for ricedroid poco F1 too)

athizz2005 commented 1 year ago

from u releases it looks like u dont maintain a proper tree u are using Excraze (Shikhar) trees from long as the dt u submitted is hard reset and only bringup commit is there all the history is deleted from August 2023- November2022

Finnaib commented 1 year ago

Yes sir I do use his trees as since base since long time because at time of ricedroid we using that trees for ricedroid so i am using it again now

athizz2005 commented 1 year ago

u did not answer my main question why was it hard reset

Finnaib commented 1 year ago

u did not answer my main question why was it hard reset Because that's was our old ricedroid period trees and after that our exam started so we not committed there

athizz2005 commented 1 year ago

i would ask u to rebase it from lineageOS trees with some improvements then re-apply again later...(2 commits for official rising) i have checked other repo in ur git none of the device works seems properly commited by you all are forks from other repos.

Finnaib commented 1 year ago

i would ask u to rebase it from lineageOS trees with some improvements then re-apply again later...(2 commits for official rising) i have checked other repo in ur git none of the device works seems properly commited by you all are forks from other repos.

It's already rebase from lineageos

athizz2005 commented 1 year ago

i cant see a single commit by you except the bringup commit

Finnaib commented 1 year ago

Sir because no need for extra commits now even lineageos beryllium u can't see it any new commits after 1 November 2022 But running well that rom so sometimes we don't need extra commit