RisingOSS-devices / official

RisingOS Code of Conducts
4 stars 5 forks source link

New maintainer for Raven #20

Closed Jrcable1 closed 9 months ago

Jrcable1 commented 10 months ago

Device you want to apply for

Your device name and codename
``` Raven

## Email address
```jrcable1@gmail.com
For contact purposes
```jrcable0@gmail.com

## Device tree sources
https://github.com/Jrcable1
## Link to the platform where you have released your unofficial build

https://drive.google.com/drive/folders/1HyHvAmiwF5zdZv6xbXD5YXO6_AsUGR53


## Other ROM's you maintain officially or unofficially

Insert here ``Pixel 6 pro Rising(unofficial) Pixel 6 pro Matrixx (personal) Samsung Galaxy Tab S6 lite WiFi (gta4xlwifi) Matrixx Official

Bugs on unofficial build

None

How long have you been building for?

Weeks/Months/Years

On and off for years. Started Raven on 09/01/2023

SELinux status?

Enforcing/Permissive.

Default

Are you using a prebuilt kernel? If yes, why?

Yes, included in rom, prebuilt is easier on my system vs building in line

Contact

Telegram username


Your Telegram username
```jrcable2
Jrcable1 commented 10 months ago

If I need to add/edit above let me know. I own 2 Pixel 6 Pro's (Raven) I use one to flash/test builds before release and the other as my daily driver

Jrcable1 commented 9 months ago

So, what changed that caused this to need improvement once it was already approved? What do I need to fix/change?

manidweep commented 9 months ago

i dont see any much work that on you did on the device expect bringup on the tree which you forked from the lead's raviole repo, so yea i changed the assignee to myself since i am the handler for rising

Jrcable1 commented 9 months ago

i dont see any much work that on you did on the device expect bringup on the tree which you forked from the lead's raviole repo, so yea i changed the assignee to myself since i am the handler for rising

OK well cool, since Rising is rebasing to lineage, won't be an issue anymore. I'll upload my lineage trees and everything will be good

manidweep commented 9 months ago

also your telegram bio is false, you are not official I see you have not changed that since last time any comment on that?

Jrcable1 commented 9 months ago

also your telegram bio is false, you are not official I see you have not changed that since last time any comment on that?

No need. Thanks for confirming this is about Albino

manidweep commented 9 months ago

why are you keeping your bio as official when you are clearly not yet? and this is not about Albino official status is a title given to a maintainer who has applied and approved for the team I dont see where you got approved yet?

Jrcable1 commented 9 months ago

Actually, I WAS official, Read above, Alvin approved an you jumped in and said no. So, technically I was official and you decided to change that

manidweep commented 9 months ago

I can jump in cause im core and the official handler for the team i dont see your work anywhere so i removed it i had a valid reason to

Jrcable1 commented 9 months ago

Well, like I said, I'll upload change everything to lineage and then no more issues

Jrcable1 commented 9 months ago

And Lead uses pixel 6, 6 pro and 6 uses same trees so we will always conflict

manidweep commented 9 months ago

the thing is last time i checked which was 6 months ago, your bio was official rising maintainer just want to clear that part, why?

manidweep commented 9 months ago

And Lead uses pixel 6, 6 pro and 6 uses same trees so we will always conflict

there is a thing known as branches? you can clearly push to a different branch

Jrcable1 commented 9 months ago

the thing is last time i checked which was 6 months ago, your bio was official rising maintainer just want to clear that part, why?

Nope. I changed it, it was Rising raven maintainer. Its been raven maintainer for awhile now. Read

Jrcable1 commented 9 months ago

Then when Alvin approved, I changer it to official

manidweep commented 9 months ago

push your trees and ping here ill check when possible

Jrcable1 commented 9 months ago

Gotcha. Already working on it. I have not yet decided if I want to switch to lineage kernel or keep prebuilt kernel in source. Rising is optimized for either/or and Android 14 for some, forces full lto in kernel to build or errors will happen. Easily fixed by chnaging to THIN LTO in gki_defconfig but still...

Jrcable1 commented 9 months ago

Messaged in telegram

Jrcable1 commented 9 months ago

Updated trees, all lineage 21 based except kernel gs201 fro evox if need to use instead of prebuilt @manidweep

Jrcable1 commented 9 months ago

Waiting on updated @manidweep

Jrcable1 commented 9 months ago

I feel like I'm being ignored @manidweep

manidweep commented 9 months ago

i'm busy man, @Jrcable1 this isnt my only job ill get back to you

Jrcable1 commented 8 months ago

@manidweep any update?

Jrcable1 commented 8 months ago

Added to official/unofficial because I have now became official matrixx ROM maintainer for the Samsung Galaxy Tab S6 lite Wifi