RisingOSS-devices / official

RisingOS Code of Conducts
4 stars 6 forks source link

New maintainer #68

Closed DeandraAir closed 2 months ago

DeandraAir commented 3 months ago

Device you want to apply for

Poco M5 4G / Redmi 11 Prime 4G (rock/stone).

Email address

affaantuh407@gmail.com

Device tree sources

https://github.com/DeandraAir/android_device_xiaomi_rock
https://github.com/DeandraAir/kernel_xiaomi_rock-prebuilts
https://github.com/DeandraAir/vendor_xiaomi_rock

Link to the platform where you have released your unofficial build

https://t.me/PocoM5IDC/226

Other ROM's you maintain officially or unofficially

EvolutionX & AwakenOS (unofficial).

Bugs on unofficial build

None

How long have you been building for?

1 Years.

SELinux status?

Enforcing.

Are you using a prebuilt kernel? If yes, why?

yes, because there are no kernel sources yet.

Contact

Telegram username

 @DeanPerformer
RisenID commented 3 months ago

Hey, any reason for this? https://github.com/DeandraAir/android_device_xiaomi_rock/commit/ebe228db52b668782f0d371e339e8f692f196106

DeandraAir commented 3 months ago

Hey, any reason for this? DeandraAir/android_device_xiaomi_rock@ebe228d

for delete unwanted apps because many user not need it

RisenID commented 3 months ago

Hey, any reason for this? DeandraAir/android_device_xiaomi_rock@ebe228d

for delete unwanted apps because many user not need it

We already have multiple flags (around 3) for different levels of gapps to be included in the build. Why not use one of those?

DeandraAir commented 3 months ago

Hai, ada alasan untuk ini? DeandraAir/android_device_xiaomi_rock@ebe228d

untuk menghapus aplikasi yang tidak diinginkan karena banyak pengguna tidak membutuhkannya

Kami sudah memiliki beberapa flag (sekitar 3) untuk berbagai level gapps yang akan disertakan dalam build. Mengapa tidak menggunakan salah satunya?

I want to provide a flexible ROM for users who don't want to depend on certain GApps. This allows them to select and install applications according to their needs.

RisenID commented 3 months ago

Hai, ada alasan untuk ini? DeandraAir/android_device_xiaomi_rock@ebe228d

untuk menghapus aplikasi yang tidak diinginkan karena banyak pengguna tidak membutuhkannya

Kami sudah memiliki beberapa flag (sekitar 3) untuk berbagai level gapps yang akan disertakan dalam build. Mengapa tidak menggunakan salah satunya?

I want to provide a flexible ROM for users who don't want to depend on certain GApps. This allows them to select and install applications according to their needs.

This is already what the gms core flag, vanilla build flag, full gapps build flag and corge gapps with some more extras are for. Why use removepackages to remove so many apps rather than just using the core gapps flag?

DeandraAir commented 3 months ago

Hai, ada alasan untuk ini? DeandraAir/android_device_xiaomi_rock@ebe228d

untuk menghapus aplikasi yang tidak diinginkan karena banyak pengguna tidak membutuhkannya

Kami sudah memiliki beberapa flag (sekitar 3) untuk berbagai level gapps yang akan disertakan dalam build. Mengapa tidak menggunakan salah satunya?

Saya ingin menyediakan ROM yang fleksibel bagi pengguna yang tidak ingin bergantung pada GApps tertentu. Ini memungkinkan mereka untuk memilih dan menginstal aplikasi sesuai dengan kebutuhan mereka.

Inilah yang menjadi tujuan flag inti gms, flag build vanilla, flag build gapps lengkap, dan corge gapps dengan beberapa tambahan lainnya. Mengapa menggunakan removepackages untuk menghapus begitu banyak aplikasi daripada hanya menggunakan flag gapps inti?

Because after switching to the oss vendor, none of us made vanilla builds, because gapps cannot be installed just like a regular gapps installation, those who want to install Gapps on vanilla builds must be rw first, because it will skip the gapps installation step if you don't rw, therefore we use (removePackage) to replace it Vanilla builds that can't install gapps

RisenID commented 3 months ago

This isnt making any sense to me, if you want a vanilla build, just dont use the dms flag. If you want only basic gapps use the gms core flag, if you want more than that, use gms core and gms core extra flag and if you want all gapps, use gms flag. There is absolutely no need for remove packages.

DeandraAir commented 3 months ago

This isnt making any sense to me, if you want a vanilla build, just dont use the dms flag. If you want only basic gapps use the gms core flag, if you want more than that, use gms core and gms core extra flag and if you want all gapps, use gms flag. There is absolutely no need for remove packages.

The Poco M5 only has a 4GB RAM variant. If I only build the core build, the size is still quite large and feels heavy for multitasking because your RAM is narrow. If I build vanilla, then they have to do RW first, so that's why we use removePackage. I will revert it if this is not allowed in RisingOS

RisenID commented 2 months ago

Hey, thanks for the application. However since applications for A14 are closed, your application is denied. Please feel free to apply again in the future, once A15 sources from us release, and once you have more experience under your belt.