RisingOSS-devices / official

RisingOS Code of Conducts
4 stars 6 forks source link

New maintainer for Mi9 #82

Open tribual opened 2 days ago

tribual commented 2 days ago

Device you want to apply for

Xiaomi Mi 9 (cepheus)

Email address

tribual@web.de

Device tree sources

https://github.com/tribual/device_xiaomi_cepheus/tree/15_no_EROFS
https://github.com/tribual/kernel_xiaomi_cepheus/tree/15_inf_noErofs
https://github.com/tribual/vendor_xiaomi_cepheus/tree/15

Link to the platform where you have released your unofficial build

https://t.me/tribual_mi9

Other ROM's you maintain officially or unofficially

Bootleggers 

Bugs on unofficial build

None

How long have you been building for?

several Years

SELinux status?

Enforcing

Are you using a prebuilt kernel? If yes, why?

No.

Contact

Telegram username

tribual
joshuah345 commented 2 days ago

As part of the process for adding new officially supported devices, we expect to include your relevant trees in this organization as well. Your device tree has some concerns that should be adressed.

  1. Commit history and quality I would advise making a dedicated branch with the needed commits for RisingOS only. In the given branch of your device tree, i have seen that this tree was migrated from an Evolution X one, at the same time you already have quite a few dedicated branches for other ROMs. I also see EPPE (ensure product packages exists) disabled, which is not recommended since this would simply skip non existent packages during a build, no matter if you really do require them or not.
  1. Data encryption disabled This form of data security is default and has been enforced for android devices for quite some time now. User apps may check for a device is encrypted and deny usage of them as well. Only custom recoveries such as TWRP (and forks like OrangeFox) may opt to mount data where FBEv2 should be already be supported anyway. Even if you do not have a custom recovery with encryption support, this doesn't prevent you from installing builds.
tribual commented 20 hours ago

Thank you for your advices.

If any other changes are wanted, just let me know, so I will do my best to get it done.

Here the actual device tree with its own branch:

https://github.com/tribual/device_xiaomi_cepheus/tree/RicingOS