search

RisingStack / trace-nodejs

Trace is a visualised distributed tracing platform designed for microservices.
https://trace.risingstack.com
Other
471 stars 90 forks source link

crash on circular references #120

Closed mathieudutour closed 8 years ago

mathieudutour commented 8 years ago

JSON.stringify crashes on circular dependencies here: https://github.com/RisingStack/trace-nodejs/blob/master/lib/agent/api/index.js#L67

Probably want to use https://github.com/isaacs/json-stringify-safe. Do you accept PR?

dszakallas commented 8 years ago

Hey! Thanks for reporting this issue. We accept PRs for course, however in this case I start fixing it ASAP, as it is quite urgent.

dszakallas commented 8 years ago

The fix was landed in v2.27.2. Thanks!