search

RisingStack / trace-nodejs

Trace is a visualised distributed tracing platform designed for microservices.
https://trace.risingstack.com
Other
471 stars 90 forks source link

node v7 support? #121

Closed bonesoul closed 7 years ago

bonesoul commented 8 years ago

any eta on it?

dszakallas commented 8 years ago

Hey Hüseyin, we are already running our CI tests against latest v7, and there seem to be no changes in the Node API changes that affect us.

bonesoul commented 8 years ago

actually there is.

check this

https://github.com/node-inspector/v8-profiler/issues/99 and this

http://pastebin.com/pwGNWyAy

dszakallas commented 8 years ago

hmm, yes, you are right, memory and cpu profiling won't work. However this problem does not affect other functionality such as tracing, APM, request metrics and the security feature.

bonesoul commented 8 years ago

yes right now i do run track over 7.0.0 and exactly only memory & cpu profiling doesn't work. But what i think is that once v8-profiler bug is resolved, i guess it'll all good.

I think it's a nice idea to track the issue.

bonesoul commented 7 years ago

@szdavid92 any updates on this?

dszakallas commented 7 years ago

@bonesoul sorry I forgot to get back to you with this. We forked the v8-profiler and fixed it for v7. Agents starting from 3.0.3 should work on v7 already.

bonesoul commented 7 years ago 
i'm using trace 3.2.0 with node 7 but still getting this build error;

λ npm install

> @risingstack/v8-profiler@5.7.0 preinstall E:\Coding\buharmetre\node_modules\.staging\@risingstack\v8-profiler-13c695a2
> node -e 'process.exit(0)'

> @risingstack/v8-profiler@5.7.0 install E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler
> node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(404): https://node-inspector.s3.amazonaws.com/profiler/v5.7.0/node-v51-win32-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for @risingstack/v8-profiler@5.7.0 and node@7.5.0 (node-v51 ABI) (falling back to source compile with node-gyp)

E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler {git}{hg}
{lamb} if not defined npm_config_node_gyp (node "C:\Users\shala\AppData\Roaming\nvm\v7.5.0\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" clean )  else (node "" clean )

E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler {git}{hg}
{lamb} if not defined npm_config_node_gyp (node "C:\Users\shala\AppData\Roaming\nvm\v7.5.0\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" configure --fallback-to-build --module=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64\profiler.node --module_name=profiler --module_path=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64 )  else (node "" configure --fallback-to-build --module=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64\profiler.node --module_name=profiler --module_path=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64 )

E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler {git}{hg}
{lamb} if not defined npm_config_node_gyp (node "C:\Users\shala\AppData\Roaming\nvm\v7.5.0\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" build --fallback-to-build --module=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64\profiler.node --module_name=profiler --module_path=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64 )  else (node "" build --fallback-to-build --module=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64\profiler.node --module_name=profiler --module_path=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64 )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  profiler.cc
  cpu_profiler.cc
  cpu_profile.cc
  cpu_profile_node.cc
  heap_profiler.cc
  heap_snapshot.cc
  heap_output_stream.cc
  heap_graph_node.cc
..\src\heap_snapshot.cc(148): warning C4244: 'argument': conversion from 'int64_t' to 'uint32_t', possible loss of data [E:\
Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler.vcxproj]
..\src\heap_graph_node.cc(69): warning C4996: 'v8::Object::Has': was declared deprecated [E:\Coding\buharmetre\node_modules\
@risingstack\v8-profiler\build\profiler.vcxproj]
  c:\users\shala\.node-gyp\7.5.0\include\node\v8.h(2746): note: see declaration of 'v8::Object::Has'
e:\coding\buharmetre\node_modules\nan\nan_new.h(208): warning C4244: 'argument': conversion from 'int64_t' to 'double', poss
ible loss of data (compiling source file ..\src\cpu_profile.cc) [E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\
build\profiler.vcxproj]
  ..\src\cpu_profile.cc(82): note: see reference to function template instantiation 'v8::Local<v8::Number> Nan::New<v8::Numb
  er,int64_t>(A0)' being compiled
          with
          [
              A0=int64_t
          ]
e:\coding\buharmetre\node_modules\nan\nan_new.h(208): warning C4244: 'argument': conversion from 'std::size_t' to 'double',
possible loss of data (compiling source file ..\src\heap_graph_node.cc) [E:\Coding\buharmetre\node_modules\@risingstack\v8-p
rofiler\build\profiler.vcxproj]
  ..\src\heap_graph_node.cc(126): note: see reference to function template instantiation 'v8::Local<v8::Number> Nan::New<v8:
  :Number,std::size_t>(std::A0)' being compiled
          with
          [
              A0=std::size_t
          ]
  heap_graph_edge.cc
  win_delay_load_hook.cc

                                     LINK : fatal error LNK1194: cannot delay-load 'node.exe' due to import of data symbol '"__declspec(dllimport) const v8::Acti
vityControl::`vftable'" (__imp_??_7ActivityControl@v8@@6B@)'; link without /DELAYLOAD:node.exe [E:\Coding\buharmetre\node_mo
dules\@risingstack\v8-profiler\build\profiler.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\shala\AppData\Roaming\nvm\v7.5.0\node_modules\npm\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:192:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Windows_NT 10.0.14393
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\shala\\AppData\\Roaming\\nvm\\v7.5.0\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "build" "--fallback-to-build" "--module=E:\\Coding\\buharmetre\\node_modules\\@risingstack\\v8-profiler\\build\\profiler\\v5.7.0\\node-v51-win32-x64\\profiler.node" "--module_name=profiler" "--module_path=E:\\Coding\\buharmetre\\node_modules\\@risingstack\\v8-profiler\\build\\profiler\\v5.7.0\\node-v51-win32-x64"
gyp ERR! cwd E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler
gyp ERR! node -v v7.5.0
gyp ERR! node-gyp -v v3.5.0
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute 'node-gyp.cmd build --fallback-to-build --module=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64\profiler.node --module_name=profiler --module_path=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (E:\Coding\buharmetre\node_modules\node-pre-gyp\lib\util\compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:106:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:192:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:890:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
node-pre-gyp ERR! System Windows_NT 10.0.14393
node-pre-gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "E:\\Coding\\buharmetre\\node_modules\\node-pre-gyp\\bin\\node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler
node-pre-gyp ERR! node -v v7.5.0
node-pre-gyp ERR! node-pre-gyp -v v0.6.33
node-pre-gyp ERR! not ok
Failed to execute 'node-gyp.cmd build --fallback-to-build --module=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64\profiler.node --module_name=profiler --module_path=E:\Coding\buharmetre\node_modules\@risingstack\v8-profiler\build\profiler\v5.7.0\node-v51-win32-x64' (1)
BuharMetre.com@0.7.4-g E:\Coding\buharmetre
+-- bcryptjs@2.4.3
+-- express-beautifier@0.1.4
| `-- js-beautify@1.6.8
+-- UNMET PEER DEPENDENCY grunt@1.0.1
+-- html-minifier@3.3.1
| `-- clean-css@4.0.5
`-- parse-domain@1.1.0

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: @risingstack/v8-profiler@5.7.0 (node_modules\@risingstack\v8-profiler):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: @risingstack/v8-profiler@5.7.0 install: `node-pre-gyp install --fallback-to-build`
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1
bonesoul commented 7 years ago

and here is another build log from my ubuntu 14.04 + node 7.5 setup;

 CXX(target) Release/obj.target/profiler/src/heap_snapshot.o
../src/heap_snapshot.cc: In static member function ‘static Nan::NAN_GETTER_RETURN_TYPE nodex::Snapshot::GetRoot(v8::Local<v8::String>, Nan::NAN_GETTER_ARGS_TYPE)’:
../src/heap_snapshot.cc:46:46: error: ‘class v8::Object’ has no member named ‘GetHiddenValue’
       info.GetReturnValue().Set(info.This()->GetHiddenValue(__root));
                                              ^
../src/heap_snapshot.cc:50:20: error: ‘class v8::Object’ has no member named ‘SetHiddenValue’
       info.This()->SetHiddenValue(__root, _root);

> @risingstack/v8-profiler@5.7.0 install /var/www/buharmetre/node_modules/@risingstack/v8-profiler
> node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(404): https://node-inspector.s3.amazonaws.com/profiler/v5.7.0/node-v51-linux-x64.tar.gz 
node-pre-gyp ERR! Pre-built binaries not found for @risingstack/v8-profiler@5.7.0 and node@7.5.0 (node-v51 ABI) (falling back to source compile with node-gyp) 
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/var/www/buharmetre/node_modules/@risingstack/v8-profiler/build'
  CXX(target) Release/obj.target/profiler/src/profiler.o
  CXX(target) Release/obj.target/profiler/src/cpu_profiler.o
  CXX(target) Release/obj.target/profiler/src/cpu_profile.o
  CXX(target) Release/obj.target/profiler/src/cpu_profile_node.o
  CXX(target) Release/obj.target/profiler/src/heap_profiler.o
  CXX(target) Release/obj.target/profiler/src/heap_snapshot.o
  CXX(target) Release/obj.target/profiler/src/heap_output_stream.o
  CXX(target) Release/obj.target/profiler/src/heap_graph_node.o
  CXX(target) Release/obj.target/profiler/src/heap_graph_edge.o
  SOLINK_MODULE(target) Release/obj.target/profiler.node
  COPY Release/profiler.node
  COPY /var/www/buharmetre/node_modules/@risingstack/v8-profiler/build/profiler/v5.7.0/node-v51-linux-x64/profiler.node
  TOUCH Release/obj.target/action_after_build.stamp
make: Leaving directory `/var/www/buharmetre/node_modules/@risingstack/v8-profiler/build'

> @risingstack/trace@3.2.0 install /var/www/buharmetre/node_modules/@risingstack/trace
> npm i v8-profiler --build-from-source || exit 0

> v8-profiler@5.6.5 preinstall /var/www/buharmetre/node_modules/@risingstack/trace/node_modules/.staging/v8-profiler-7bcb749a
> node -e 'process.exit(0)'

> v8-profiler@5.6.5 install /var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler
> node-pre-gyp install --fallback-to-build

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler/build'
  CXX(target) Release/obj.target/profiler/src/profiler.o
  CXX(target) Release/obj.target/profiler/src/cpu_profiler.o
  CXX(target) Release/obj.target/profiler/src/cpu_profile.o
  CXX(target) Release/obj.target/profiler/src/cpu_profile_node.o
  CXX(target) Release/obj.target/profiler/src/heap_profiler.o
  CXX(target) Release/obj.target/profiler/src/heap_snapshot.o
../src/heap_snapshot.cc: In static member function ‘static Nan::NAN_GETTER_RETURN_TYPE nodex::Snapshot::GetRoot(v8::Local<v8::String>, Nan::NAN_GETTER_ARGS_TYPE)’:
../src/heap_snapshot.cc:46:46: error: ‘class v8::Object’ has no member named ‘GetHiddenValue’
       info.GetReturnValue().Set(info.This()->GetHiddenValue(__root));
                                              ^
../src/heap_snapshot.cc:50:20: error: ‘class v8::Object’ has no member named ‘SetHiddenValue’
       info.This()->SetHiddenValue(__root, _root);
                    ^
make: *** [Release/obj.target/profiler/src/heap_snapshot.o] Error 1
make: Leaving directory `/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:192:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Linux 4.8.6-x86_64-linode78
gyp ERR! command "/root/.nvm/versions/node/v7.5.0/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64/profiler.node" "--module_name=profiler" "--module_path=/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64"
gyp ERR! cwd /var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler
gyp ERR! node -v v7.5.0
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok 
node-pre-gyp ERR! build error 
node-pre-gyp ERR! stack Error: Failed to execute '/root/.nvm/versions/node/v7.5.0/bin/node /usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64/profiler.node --module_name=profiler --module_path=/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:106:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:192:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:890:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
node-pre-gyp ERR! System Linux 4.8.6-x86_64-linode78
node-pre-gyp ERR! command "/root/.nvm/versions/node/v7.5.0/bin/node" "/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler
node-pre-gyp ERR! node -v v7.5.0
node-pre-gyp ERR! node-pre-gyp -v v0.6.33
node-pre-gyp ERR! not ok 
Failed to execute '/root/.nvm/versions/node/v7.5.0/bin/node /usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64/profiler.node --module_name=profiler --module_path=/var/www/buharmetre/node_modules/@risingstack/trace/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64' (1)
npm ERR! Linux 4.8.6-x86_64-linode78
npm ERR! argv "/root/.nvm/versions/node/v7.5.0/bin/node" "/root/.nvm/versions/node/v7.5.0/bin/npm" "i" "v8-profiler" "--build-from-source"
npm ERR! node v7.5.0
npm ERR! npm  v4.1.2
npm ERR! code ELIFECYCLE

npm ERR! v8-profiler@5.6.5 install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the v8-profiler@5.6.5 install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the v8-profiler package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs v8-profiler
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls v8-profiler
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /var/www/buharmetre/node_modules/@risingstack/trace/npm-debug.log
bonesoul commented 7 years ago

given another test with ubuntu 14.04 box;

node --version
v7.5.0

installed using nvm.

I've downloaded clean install of risingstack/v8-profiler;

git clone https://github.com/RisingStack/trace-nodejs.git

then issued a build;

npm install

and it seems the fixes [https://github.com/RisingStack/v8-profiler/commit/81bb0321a3469c6625dcf687df43283fe6e288ac] actually are somehow ignored;

npm WARN deprecated npmconf@2.1.2: this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN deprecated @bahmutov/parse-github-repo-url@0.1.2: All features were merged back into original parse-github-repo-url
npm WARN deprecated conventional-changelog@0.0.17: Please update conventional-changelog to >1.0.0. If you are running the cli, use conventional-changelog-cli
npm WARN deprecated node-uuid@1.4.7: use uuid module instead

> @risingstack/v8-profiler@5.7.0 preinstall /root/trace-nodejs/node_modules/.staging/@risingstack/v8-profiler-373ea9eb
> node -e 'process.exit(0)'

> @risingstack/v8-profiler@5.7.0 install /root/trace-nodejs/node_modules/@risingstack/v8-profiler
> node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(404): https://node-inspector.s3.amazonaws.com/profiler/v5.7.0/node-v51-linux-x64.tar.gz 
node-pre-gyp ERR! Pre-built binaries not found for @risingstack/v8-profiler@5.7.0 and node@7.5.0 (node-v51 ABI) (falling back to source compile with node-gyp) 
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/root/trace-nodejs/node_modules/@risingstack/v8-profiler/build'
  CXX(target) Release/obj.target/profiler/src/profiler.o
  CXX(target) Release/obj.target/profiler/src/cpu_profiler.o
  CXX(target) Release/obj.target/profiler/src/cpu_profile.o
  CXX(target) Release/obj.target/profiler/src/cpu_profile_node.o
  CXX(target) Release/obj.target/profiler/src/heap_profiler.o
  CXX(target) Release/obj.target/profiler/src/heap_snapshot.o
  CXX(target) Release/obj.target/profiler/src/heap_output_stream.o
  CXX(target) Release/obj.target/profiler/src/heap_graph_node.o
  CXX(target) Release/obj.target/profiler/src/heap_graph_edge.o
  SOLINK_MODULE(target) Release/obj.target/profiler.node
  COPY Release/profiler.node
  COPY /root/trace-nodejs/node_modules/@risingstack/v8-profiler/build/profiler/v5.7.0/node-v51-linux-x64/profiler.node
  TOUCH Release/obj.target/action_after_build.stamp
make: Leaving directory `/root/trace-nodejs/node_modules/@risingstack/v8-profiler/build'

> event-loop-stats@1.0.0 install /root/trace-nodejs/node_modules/event-loop-stats
> node-gyp rebuild

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/root/trace-nodejs/node_modules/event-loop-stats/build'
  CXX(target) Release/obj.target/eventLoopStats/src/eventLoopStats.o
  SOLINK_MODULE(target) Release/obj.target/eventLoopStats.node
  COPY Release/eventLoopStats.node
make: Leaving directory `/root/trace-nodejs/node_modules/event-loop-stats/build'

> gc-stats@1.0.0 install /root/trace-nodejs/node_modules/gc-stats
> node-gyp rebuild

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/root/trace-nodejs/node_modules/gc-stats/build'
  CXX(target) Release/obj.target/gcstats/src/gcstats.o
  SOLINK_MODULE(target) Release/obj.target/gcstats.node
  COPY Release/gcstats.node
make: Leaving directory `/root/trace-nodejs/node_modules/gc-stats/build'

> microtime@2.1.2 install /root/trace-nodejs/node_modules/microtime
> node-gyp rebuild

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/root/trace-nodejs/node_modules/microtime/build'
  CXX(target) Release/obj.target/microtime/src/microtime.o
  SOLINK_MODULE(target) Release/obj.target/microtime.node
  COPY Release/microtime.node
make: Leaving directory `/root/trace-nodejs/node_modules/microtime/build'

> pre-commit@1.2.1 install /root/trace-nodejs/node_modules/pre-commit
> node install.js

> spawn-sync@1.0.15 postinstall /root/trace-nodejs/node_modules/spawn-sync
> node postinstall

> @risingstack/trace@3.2.1 install /root/trace-nodejs
> npm i v8-profiler --build-from-source || exit 0

> v8-profiler@5.6.5 preinstall /root/trace-nodejs/node_modules/.staging/v8-profiler-dd485cd1
> node -e 'process.exit(0)'

> v8-profiler@5.6.5 install /root/trace-nodejs/node_modules/v8-profiler
> node-pre-gyp install --fallback-to-build

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/root/trace-nodejs/node_modules/v8-profiler/build'
  CXX(target) Release/obj.target/profiler/src/profiler.o
  CXX(target) Release/obj.target/profiler/src/cpu_profiler.o
  CXX(target) Release/obj.target/profiler/src/cpu_profile.o
  CXX(target) Release/obj.target/profiler/src/cpu_profile_node.o
  CXX(target) Release/obj.target/profiler/src/heap_profiler.o
  CXX(target) Release/obj.target/profiler/src/heap_snapshot.o
../src/heap_snapshot.cc: In static member function ‘static Nan::NAN_GETTER_RETURN_TYPE nodex::Snapshot::GetRoot(v8::Local<v8::String>, Nan::NAN_GETTER_ARGS_TYPE)’:
../src/heap_snapshot.cc:46:46: error: ‘class v8::Object’ has no member named ‘GetHiddenValue’
       info.GetReturnValue().Set(info.This()->GetHiddenValue(__root));
                                              ^
../src/heap_snapshot.cc:50:20: error: ‘class v8::Object’ has no member named ‘SetHiddenValue’
       info.This()->SetHiddenValue(__root, _root);
                    ^
make: *** [Release/obj.target/profiler/src/heap_snapshot.o] Error 1
make: Leaving directory `/root/trace-nodejs/node_modules/v8-profiler/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:192:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Linux 4.8.6-x86_64-linode78
gyp ERR! command "/root/.nvm/versions/node/v7.5.0/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/root/trace-nodejs/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64/profiler.node" "--module_name=profiler" "--module_path=/root/trace-nodejs/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64"
gyp ERR! cwd /root/trace-nodejs/node_modules/v8-profiler
gyp ERR! node -v v7.5.0
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok 
node-pre-gyp ERR! build error 
node-pre-gyp ERR! stack Error: Failed to execute '/root/.nvm/versions/node/v7.5.0/bin/node /usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/root/trace-nodejs/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64/profiler.node --module_name=profiler --module_path=/root/trace-nodejs/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/root/trace-nodejs/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:106:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:192:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:890:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
node-pre-gyp ERR! System Linux 4.8.6-x86_64-linode78
node-pre-gyp ERR! command "/root/.nvm/versions/node/v7.5.0/bin/node" "/root/trace-nodejs/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /root/trace-nodejs/node_modules/v8-profiler
node-pre-gyp ERR! node -v v7.5.0
node-pre-gyp ERR! node-pre-gyp -v v0.6.33
node-pre-gyp ERR! not ok 
Failed to execute '/root/.nvm/versions/node/v7.5.0/bin/node /usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/root/trace-nodejs/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64/profiler.node --module_name=profiler --module_path=/root/trace-nodejs/node_modules/v8-profiler/build/profiler/v5.6.5/node-v51-linux-x64' (1)
npm ERR! Linux 4.8.6-x86_64-linode78
npm ERR! argv "/root/.nvm/versions/node/v7.5.0/bin/node" "/root/.nvm/versions/node/v7.5.0/bin/npm" "i" "v8-profiler" "--build-from-source"
npm ERR! node v7.5.0
npm ERR! npm  v4.1.2
npm ERR! code ELIFECYCLE

npm ERR! v8-profiler@5.6.5 install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the v8-profiler@5.6.5 install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the v8-profiler package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs v8-profiler
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls v8-profiler
npm ERR! There is likely additional logging output above.

@gergelyke any ideas?

bonesoul commented 7 years ago

found the issue, sent you a PR guys :) https://github.com/RisingStack/trace-nodejs/pull/129

dszakallas commented 7 years ago

Thanks @bonesoul . Good catch, we overlooked this :)