RiskProtocol / core-protocol

1 stars 0 forks source link

Work on Scheduled Rebases #150

Closed Tunji17 closed 7 months ago

Tunji17 commented 8 months ago

Uses mapping to store scheduled rebase instead of array to preserve sequence number order Add function to execute queued rebases in groups of 5 Refactor deployment scripts to work locally and on any network Refactor tests to use signRebase function to generate the signature and encodedData for triggering rebase instead of hardcoding it Adds check to revert adding a natural rebase to queue before it's time interval Adds more tests for the rebase sequences and executing scheduled rebases left behind in queue

Note: i still have one test failing for the management fees, I do not fully understand how the calculations are done so not sure where this error is coming from. the test is also failing in the base branch and @haidarally will be in the best position to resolve it when he's back

image
openzeppelin-code[bot] commented 8 months ago

Uses mapping to store scheduled rebase instead of array, add function…

Generated at commit: dd23b0575ccae4462f82645af41ca4be8767e05d

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector low
note
Total
6
30
36
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code