search

RiskProtocol / core-protocol

1 stars 0 forks source link

Erc-20-Permit and nonce implementation #157

Open mz7mz7mz7 opened 7 months ago

mz7mz7mz7 commented 7 months ago

This implementation of ERC-20-Permit uses nonces: https://github.com/soliditylabs/ERC20-Permit/blob/main/contracts/ERC20Permit.sol

Task for us: review if we should also use them and if we use them properly.

haidarally commented 7 months ago

@mz7mz7mz7

ERC20Permit from OZ also makes use of user's nonce https://github.com/OpenZeppelin/openzeppelin-contracts/blob/ef699fa6a224de863ffe48347a5ab95d3d8ba2ba/contracts/token/ERC20/extensions/ERC20Permit.sol#L57

The only difference i see is soliditylabs using assembly while Oz uses solidity Therefore, I think we are good with OZ what do you think?

@mz7mz7mz7