search

RiskProtocol / core-protocol

2 stars 0 forks source link

EIP-4626 (Tokenized Vaults) implementation in TokenFactory #20

Closed mz7mz7mz7 closed 1 year ago

mz7mz7mz7 commented 1 year ago

It seems that our TokenFactory contract would be more composable and interoperable if we adhere to this interface/standard.

spec: https://eips.ethereum.org/EIPS/eip-4626 minimal reference impl: https://github.com/transmissions11/solmate/blob/main/src/mixins/ERC4626.sol

jiokeokwuosa commented 1 year ago

i have looked at the implementation and the contract on OpenZeppelin, we will not be able to use it out of the box because it supports a single asset and our use-case is 2 assets but we can upgrade what we currently have to look like the standard eg add some methods the standard has that we don't currently implement eg totalAssets, maximumWithdrawal etc, update the events