search

RiskProtocol / core-protocol

2 stars 0 forks source link

EIP-2612 #3

Open mz7mz7mz7 opened 1 year ago

mz7mz7mz7 commented 1 year ago

Add EIP-2612 support to our ERC-20 contracts. https://eips.ethereum.org/EIPS/eip-2612

jiokeokwuosa commented 1 year ago

Waiting for review

mz7mz7mz7 commented 1 year ago

https://github.com/RiskProtocol/core-protocol/pull/19 is merged, but please also create unit tests testing this functionality before we close the task.

jiokeokwuosa commented 1 year ago

ok

mz7mz7mz7 commented 1 year ago

Were the unit tests created please @jiokeokwuosa ?

jiokeokwuosa commented 1 year ago

not yet, i can do that next sprint where i have task on 100% unit test

mz7mz7mz7 commented 1 year ago

Assigned to @haidarally so we can double-check everything within this ticket was done and we can close it.