search

RiskProtocol / core-protocol

2 stars 0 forks source link

SC: Rounding errors: tests + handling code #61

Open mz7mz7mz7 opened 1 year ago

mz7mz7mz7 commented 1 year ago
  1. Generate use-case scenarios that demonstrate where our code generates rounding errors.
  2. Let's examine these scenarios and discuss how we should handle these cases.
  3. Implement handling logic.
mz7mz7mz7 commented 1 year ago

Please note @Tunji17 this task is actually partially overlapping with https://github.com/RiskProtocol/core-protocol/issues/66 Especially review in https://a16zcrypto.com/content/article/generalized-property-tests-for-erc4626-vaults/#section--4 section related to rounding errors (of course ERC-4626 is not the only standard we need to review in relation to rounding errors)

FYI: @jiokeokwuosa , @haidarally

Tunji17 commented 1 year ago

https://github.com/code-423n4/2022-06-notional-coop-findings/issues/155 I think this provides enough information for this implementation

Image