search

RiskProtocol / core-protocol

2 stars 0 forks source link

ERC-4626 conformance refactor + compatibility tests #66

Closed mz7mz7mz7 closed 1 year ago

mz7mz7mz7 commented 1 year ago

We were pointed (on this TG group: https://t.me/erc4626alliance ) to:

  1. https://a16zcrypto.com/content/article/generalized-property-tests-for-erc4626-vaults/
  2. https://github.com/a16z/erc4626-tests
  3. https://github.com/crytic/slither/wiki/ERC-Conformance
  4. https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/test/token/ERC20/extensions/ERC4626.test.js

Task: Find out a way for us to run all these tests against the implementation of our contract to prove it is compatible with the standard.

mz7mz7mz7 commented 1 year ago

We concluded that our implementation is not standard-compliant. And we discussed with @Tunji17 and @jiokeokwuosa how to make it standardized.

@Tunji17 was tasked with the refactor, so let's do it within this ticket, as at the end of this refactor we still have to add compatibility tests/