search

RiskProtocol / core-protocol

2 stars 0 forks source link

Foundry Advanced testing(Fuzzy) / Github actions #69

Closed jiokeokwuosa closed 1 year ago

Tunji17 commented 1 year ago

So i'm thinking we should gitignore the lib/ submodules folder. this will dramatically reduce the number of file changes and we can always add the dependencies to the READMe file forge install forge-std as requirement to run the app @jiokeokwuosa what do you think

jiokeokwuosa commented 1 year ago

So i'm thinking we should gitignore the lib/ submodules folder. this will dramatically reduce the number of file changes and we can always add the dependencies to the READMe file forge install forge-std as requirement to run the app @jiokeokwuosa what do you think

@Tunji17 Please can we have a call on this? i have tried removing it before but foundry commands stops working. The forge commands will end in an error, i have checked it out and discovered that foundry itself does not put it in gitignore when a new project is created. I have looked at other projects built on foundry here in github they all have the lib folder eg https://github.com/SunWeb3Sec/DeFiHackLabs https://github.com/PaulRBerg/foundry-template https://github.com/0xToshii/mr-steal-yo-crypto-ctf-foundry

Tunji17 commented 1 year ago

So i'm thinking we should gitignore the lib/ submodules folder. this will dramatically reduce the number of file changes and we can always add the dependencies to the READMe file forge install forge-std as requirement to run the app @jiokeokwuosa what do you think

@Tunji17 Please can we have a call on this?

@jiokeokwuosa yeah i see what you mean, installing a new submodule commit the changes directly to git so you can't ignore the changes. i think it's fine this way