RiskProtocol / core-protocol

2 stars 0 forks source link

Review ERC-223 improvement #7

Closed mz7mz7mz7 closed 1 year ago

mz7mz7mz7 commented 1 year ago

https://github.com/Dexaran/ERC223-token-standard/tree/development

mz7mz7mz7 commented 1 year ago

And decide if we should incorporate it or not in our code base, and why? If the decision is to incorporate it -- let's implement it too

jiokeokwuosa commented 1 year ago

ERC-223-->A mechanism to help prevent accidental transfer of token to contracts that are not prepared to handle them, so you have to specify the tokens you want your contract to accept... so if someone accidentally sends a token we don't want the contract will reject it. it will help prevent against lost tokens, reduce gas consumption...

From my research, some ERC20-compatible wallets and exchanges may not be able to handle ERC223 tokens without additional modifications. It is not widely accepted compared to ERC20 tokens.

ERC-223 has not been implemented as a finalized ERC token standard, and even its status as a draft has been removed.

Many of the Ethereum developers interested in solving the problems that ERC-223 is intended to address opted instead for the newer, slightly more nuanced ERC-777 token standard. Open zeppline does not have an implementation of ERC-223

mz7mz7mz7 commented 1 year ago

ok, let's review https://github.com/RiskProtocol/core-protocol/issues/6 in more details as an alternative