RiskProtocol / core-protocol

2 stars 0 forks source link

it should revert when using depositWithPermit with a regular ERC20 token without permit #71

Closed Tunji17 closed 1 year ago

Tunji17 commented 1 year ago

So i think the behavior was a bit straightforward, the IERC20Update interface extends the IERC20 and adds a permit function, the permit function was only used in depositWithPermit function in TokenFactory this is why calling deposit with a regular Erc20 token without permit works, i have added a test that calls depositWithPermit using a regular Erc20 token without permit to confirm a revert behavior.