search

RiskProtocol / core-protocol

1 stars 0 forks source link

upgrades @openzeppelin/contracts from 4.8.2 to 4.9.1 in client and root #98

Closed Tunji17 closed 1 year ago

haidarally commented 1 year ago

The only concern i see is they are deprecating ERC777 and ERC1820 and we are planning to use this for the future, is this still a good idea? https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4066

Tunji17 commented 1 year ago

The only concern i see is they are deprecating ERC777 and ERC1820 and we are planning to use this for the future, is this still a good idea? OpenZeppelin/openzeppelin-contracts#4066

@haidarally thanks for finding this, it was a minor release so not expecting a change like this. And actually we might want to rethink using ERC777 standard @mz7mz7mz7 , https://github.com/OpenZeppelin/openzeppelin-contracts/issues/2620 this is the thread i'm taking a look at

haidarally commented 1 year ago

The only concern i see is they are deprecating ERC777 and ERC1820 and we are planning to use this for the future, is this still a good idea? OpenZeppelin/openzeppelin-contracts#4066

@haidarally thanks for finding this, it was a minor release so not expecting a change like this. And actually we might want to rethink using ERC777 standard @mz7mz7mz7 , OpenZeppelin/openzeppelin-contracts#2620 this is the thread i'm taking a look at Yes agreed, we might need to reconsider

mz7mz7mz7 commented 1 year ago

The only concern i see is they are deprecating ERC777 and ERC1820 and we are planning to use this for the future, is this still a good idea? OpenZeppelin/openzeppelin-contracts#4066

@haidarally thanks for finding this, it was a minor release so not expecting a change like this. And actually we might want to rethink using ERC777 standard @mz7mz7mz7 , OpenZeppelin/openzeppelin-contracts#2620 this is the thread i'm taking a look at Yes agreed, we might need to reconsider

Moved to https://github.com/RiskProtocol/core-protocol/issues/101