search

Riskified / ios_sdk

Riskified iOS SDK
Apache License 2.0
3 stars 7 forks source link

XCFramework shouldn't be distributed with Swift standard libraries #13

Open username0x0a opened 2 years ago

username0x0a commented 2 years ago

Analysing the 1.3.0 update, I've noticed a great increase in the xcframework bundle size. Looking closely, the framework now carries Swift standard libraries. These should be only bundled to the target app if needed (and deploying to iOS 12.3 and earlier OS versions) or not at all as for later deployment targets, Swift 5 ABI compatibility handles it.

Please rebuild the xcframework without the Swift standard libraries bundled. 👍

username0x0a commented 2 years ago

Cc @mooseriskified @dormini

mooseriskified commented 2 years ago

@username0x0a fixed. We are changing the deployment target as well as additional fixes and then releasing it. We are aiming for a Friday (May/27) release

username0x0a commented 2 years ago

Thanks for info 👍 I'll be floating around to give a feedback, shall you need some before the release. 👌

adellibovi commented 2 years ago

Hello @mooseriskified , We noticed as well that the .xcframework does support bitcode. :/ Any update regarding the May/27 release?

mooseriskified commented 2 years ago

@adellibovi We moved it to Tuesday ( tomorrow ) as we identified a simple bug in the pre-release. Ill ping you once we release it

adellibovi commented 2 years ago

Will it fix also the issue mentioned about with Bitcode generation @mooseriskified ? #15

mooseriskified commented 2 years ago

@adellibovi yes that was fixed

mooseriskified commented 2 years ago

@username0x0a we fixed the issue, let me know how it looks on your end