search

Riskified / ios_sdk

Riskified iOS SDK
Apache License 2.0
3 stars 7 forks source link

1.3.1 the published RiskifiedBeaconXCFramework.podspec should not contain EXCLUDED_ARCHS #18

Open adellibovi opened 2 years ago

adellibovi commented 2 years ago

Hello, while the podspec included in this repo is correct, the one published is different and it includes:

  "user_target_xcconfig": {
    "EXCLUDED_ARCHS[sdk=iphonesimulator*]": "i386"
  },
  "pod_target_xcconfig": {
    "EXCLUDED_ARCHS[sdk=iphonesimulator*]": "i386"
  }

This is not required since the frameworks do not contain anymore that slices, and it can create issues with Cocoapods when having other xcframework with similar (but different values)

adellibovi commented 2 years ago

cc @mooseriskified

mooseriskified commented 2 years ago

@adellibovi We were running into an issue with pod release "https://github.com/CocoaPods/CocoaPods/issues/10523"

Could you elaborate on the issue you are running into?

crsantos commented 2 years ago

@mooseriskified

As @adellibovi referred, you don't include the slice i386 in the xcframework anymore, it's 32bits, so it's not a problem

This clashes with other libs that have exclusions, where cocoapods state that:

[!] Can’t merge user_target_xcconfig for pod targets: [“RiskifiedBeaconXCFramework”, “AnotherRandomLib”]. Singular build setting EXCLUDED_ARCHS[sdk=iphonesimulator*] has different values.