search

Riskified / ios_sdk

Riskified iOS SDK
Apache License 2.0
3 stars 7 forks source link

TIS-399 Package.swift Enable SPM #7

Closed danilobecke closed 9 months ago

RGG-jayoung commented 2 years ago

Has there been any progress on adding SPM support?

rogerluan commented 2 years ago

Ping @mooseriskified 😇 Perhaps this could be merged in before the next lib release which looks like it's just around the corner? 🙏

rogerluan commented 2 years ago

Ping @mooseriskified

mooseriskified commented 2 years ago

@rogerluan Thank you - ill add it this week

alfogrillo commented 2 years ago

Sorry I just noticed this PR after I opened a similar one here: https://github.com/Riskified/ios_sdk/pull/14 I just would suggest to lower the minimum iOS target to 9.0 if you don't see any problem with that.

username0x0a commented 2 years ago

Well, the framework is built with 9.0 deployment, but the xcframework bundle only contains arm64 slice for iOS devices 🤔 so it will only work on 64-bit ones. Keeping that in mind, I'd better update the whole framework to 11.0 deployment target which effectively dropped armv7 architecture for good.

Killectro commented 2 years ago

Is there any update on adding support for SPM? We would really love to use it via SPM rather than Cocoapods or manual integration

rogerluan commented 2 years ago

Ping @mooseriskified