The font collector does not work as it should

Ristellise / AegisubDC

Aegisub, Daydream Cafe Edition

Other

282 stars 31 forks source link

The font collector does not work as it should #1

Closed Makabra closed 4 years ago

Makabra commented 4 years ago

Above Daydream build, below build 8993 unknown (1)

It seems the problem is when there is more than one type of the family font. Take the regular one even if it hasn't been use.

Ristellise commented 4 years ago

Above Daydream build, below build 8993

Which build exactly, 9203?
Though it seems to be working as intended, so I'm not sure what is wrong here though.

Makabra commented 4 years ago

Yes, is the 9203.

Ristellise commented 4 years ago

I think I see the issue here, but I think it will be too hard to fix as you would have to read all the font files (Which might take a while!) and then checking them which takes even longer time. Might be not worth the time for it :/

Thought anyone wanting to tackle this, feel free.

PS. That reminds me to upload my folder. lol

Ristellise commented 4 years ago

Thanks to a hint from Ryoka on discord, narrowed down to: https://github.com/wangqr/Aegisub/commit/cd7ee8d5055b04764fc3e396cc2ab118d093f1ae

I might have a look at it soon enough...

Ristellise commented 4 years ago

Fixed in 9205 - Petzku's Club