Update to latest bs-platform

Risto-Stevcev / bastet

A ReasonML/Ocaml library for category theory and abstract algebra

BSD 3-Clause "New" or "Revised" License

211 stars 26 forks source link

Update to latest bs-platform #10

Closed mlms13 closed 5 years ago

mlms13 commented 5 years ago

This bumps the bs-platform version to 5.0.4.

string_of_float triggers a warning and recommends Js.Float.toString instead, so I made that change
dev-dependencies (bs-mocha and bs-chai) were updated to work with the latest bs-platform

I saw you made a bs-chai release on Github, but I'm not yet seeing it on npm. For now I pointed the devDependency directly at github, but I'm happy to change that back to npm once bs-chai@0.5.0 shows up there.

Risto-Stevcev commented 5 years ago

Ah my bad, I thought I published it earlier

mlms13 commented 5 years ago

No worries! I see it's there now, so I updated the dependency here.

Risto-Stevcev commented 5 years ago

Thanks! Can you squash it into one commit?

mlms13 commented 5 years ago

Please do! I didn't want to force-push, but I'm all for the squash merge.

Risto-Stevcev commented 5 years ago

Force pushing works ok with github, it'll automagically update the diff and everything

mlms13 commented 5 years ago

Ha, sorry I totally misread your previous message. :stuck_out_tongue: Here comes the squash...

mlms13 commented 5 years ago

I also threw in the .gitattributes file to get rid of the incorrect C++ language identification. Should be good to go now, if you're OK with it.

Risto-Stevcev commented 5 years ago

Thanks for the PR! :slightly_smiling_face: