Ritwika-14 / CoupEarn

Earn by selling your unused coupons.
https://coupearn.netlify.app/
10 stars 17 forks source link

Coup earn #14

Closed Sneha-Sonkar closed 9 months ago

Sneha-Sonkar commented 9 months ago

Pull Request

Title and Issue Number (mandatory)

Title : Blank Page Appears on Clicking Vacant Profile Icon

Issue No. : 5

Close # Blank Page Appears on Clicking Vacant Profile Icon Issue No. : 5

Description (30-50 words)

I added a pop up alert saying "Sign in first". Now, when the Vacant profile picture will be clicked, the pop up asking the user to sign in first will be shown.

Screenshot (mandatory)

![Uploading Screenshot 2024-01-18 192628.png…]()

Files Changed (mandatory)

Added a alert asking the user to sign in first through an onclick() function in Header.js file

Checklist: (mandatory)

Additional context

Are you contributing under any Open-source programme? Yes, I am contributing in JGEC:JWoc

netlify[bot] commented 9 months ago

Deploy Preview for melodious-boba-f07710 failed.

Name Link
Latest commit 445bb531252e8a0b19ac45e4ec273707f7d02dba
Latest deploy log https://app.netlify.com/sites/melodious-boba-f07710/deploys/65a932c80b16370008f178f6
Sneha-Sonkar commented 9 months ago

@Ritwika-14 I have committed the change and made a pull request. This is my first time so I am afraid that I might not have pushed everything properly, could you please check and confirm if I made the pull request properly? Also, I am immensely grateful to you for assigning me this issue, it is my first issue in open source. Thank you so much for giving me this wonderful opportunity to learn

Abhishek-465 commented 9 months ago

@Sneha-Sonkar See you have made a major mistake thatswhy it happened. You have written the function F1 before the Header function so it resulted into deployment error. Close this PR and make a fresh PR in a new branch rectifying the error and it will work fine✔️.

Sneha-Sonkar commented 9 months ago

Oh okay, thank you so much @Abhishek-465 .

Sneha-Sonkar commented 9 months ago

@Abhishek-465 I tried after making the required changes but it is still not deploying. Could you please help me ?