Riverscapes / QRAVEPlugin

QGIS Plugin for viewing Riverscapes projects
GNU General Public License v3.0
0 stars 0 forks source link

Images from 'dotnetack.md' not displaying images and hyperlinks go to nowhere #34

Open joewheaton opened 3 years ago

joewheaton commented 3 years ago

The Problem

The update of Acknowledgements associated with completing https://github.com/Riverscapes/RaveAddIn/issues/3 , revealed that any hyperlinks within the acknowledgements do not open in an external browser (what we want) and instead just open within the frame.

image

This is related to https://github.com/Riverscapes/RaveAddIn/issues/155 but different behavior here in the QPlugin.

Reproduction steps

Watch second part of video for behavior: Not loading https://youtu.be/Z_gW8c-Nk3U

What we'd like

Is it possible to get the images to show up and the hyperlinks to open the user's default browser?

philipbaileynar commented 3 years ago

I just tested two possible solutions. Neither worked.

Anchor target attribute

I tried putting in a HTML link with a target attributeusing the following. Weirdly, this didn't render at all and Jekyll just spat out the raw HTML in the final document. I thought straight HTML got interpreted?

<a href="https://northarrowresearch.com" target=”_blank”>NAR</a>

Markdown Attributes

I tried an approach that I found here. In ArcRAVE this did nothing. The link just opened in the About form web control. In QRAVE it just caused a blank page in the form's web control.

RAVE is brought to you for free by the [Riverscapes Consortium](http://riverscapes.xyz){:target="_blank"}
MattReimer commented 3 years ago

I suspect this could be more about configuring the control itself than anything to do with the markdown. There might be a "render images" checkbox or a "open links in browser" checkbox. I'll take a look when I'm back

MattReimer commented 3 years ago

Ok, so external links were easy but apparently the control I'm using won't do image downloads and trying to use the QWebEngineView crashes the designer immediately

I'm not alone in my frustration here: https://github.com/qgis/QGIS/issues/41381

No solution yet. We might need a workaround.

joewheaton commented 3 years ago

One work around for now is we remove images from the markdown.

So am I to understand correctly that getting the links to open in browser was okay?

MattReimer commented 3 years ago

Yeah. The browser pops open just fine.

I think the no images thing is probably the short term fix. I would like them to load (and there's no reason we shouldn't be able to do that) but the obvious fix didn't work.

I'll leave this open and we'll circle back in the next milestone.

philipbaileynar commented 2 years ago

Action required: Remove images from markdown file.

MattReimer commented 2 years ago

The short term fix is done for now. I'm pushing this issue forward so we eventually get a proper fix