Riverscapes / QRAVEPlugin

QGIS Plugin for viewing Riverscapes projects
0 stars 0 forks source link

Error Loading pyBRAT Project For Ally #43

Closed philipbaileynar closed 2 years ago

philipbaileynar commented 2 years ago

@leallysmith is experiencing a similar error to #41 when she tries to load a pyBRAT project curated by @Cashe93. Here's the error message:

image

Here is Ally's system:

Other Information:

MattReimer commented 2 years ago

Definitely a legitimate error with QRave that needs fixing

philipbaileynar commented 2 years ago

Additonal info... @leallysmith is using a computer that others in the lab were using before she started (i.e. could be dirty system with other lingering files)

philipbaileynar commented 2 years ago

I had Ally email me her pBRAT.xml business logic from here QRAVE resources folder.

I saved this file into my local copy of the RiverscapesXML master branch. git showed no differences, proving that her QRAVE resource folder contains the same version as GitHub master branch.

joewheaton commented 2 years ago

Not that it helps, but I just downloaded project on my QGIS (QGIS version: 3.20.0-Odense), RAVE 0.5.2 and updated recourses and confirmed I have latest pyBRAT.xml business logic. It worked for me, see: You Tube Video

@leallysmith it might be helpful for testing this if you recorded a little video of exactly what you are experiencing and posted it.

For instructions on recording videos with Faststone and posting them to YouTube, see: For instructions on how to embed videos in MarkDown posts like this, see: http://etal.joewheaton.org/faststone-capture.htmlhttps://gist.github.com/joewheaton/002acd9ea725f6d4a1bac38ee9a0dd50#embed-a-video

leallysmith commented 2 years ago

I think I embedded the video? The tutorial links lead to 404 pages. I also pasted in the youtube link itself in case my embed failed. Link Alt text

And a snip of my error code QPythonError

MattReimer commented 2 years ago

@leallysmith that's excellent. Thanks for doing that. Should really help us quickly zone in on the problem

joewheaton commented 2 years ago

@MattReimer and @philipbaileynar , @CHafen and I were just attempting (first time) to load a GUT project (see this ticket) and we get the exact same error: image

Thoughts?

MattReimer commented 2 years ago

I can't pull the code right now but these are all good data points. I'll get to it on Monday and we'll have a new release shortly after that.

joewheaton commented 2 years ago

Understood @MattReimer . It was just the first time I was able to reproduce that problem (doing something totally different). So thought I should post it here. Note this is an older version of Q (3.18 instead of 3.20).

philipbaileynar commented 2 years ago
  1. Was it working for some people and not for others?
  2. I'm pretty sure the default_view message is a red herring and just a generic fall back place in the code.
joewheaton commented 2 years ago

I don't know if any of us have ever tried to open a GUT project in QRAVE. This is first time I have seen it.

joewheaton commented 2 years ago

So @philipbaileynar, you got me thinking, I 've also never tried to open a Hydro or Topo project. See this video for rather variable results. Video

MattReimer commented 2 years ago

Ok. I've reviewed all the videos and evidence provided (big thanks @leallysmith and @joewheaton for the great vidoes) and I think I've got it covered. I'll be putting out a patch release 0.6.0 tomorrow morning and I'll let you know when you can get it and try.

Given the attention to business logic developers I've really tried to give better errors whenever possible but I'll ellaborate on that in my changelog patch notes at release time.

Cashe93 commented 2 years ago

@MattReimer, any word on the patch release?

MattReimer commented 2 years ago

I'm typing up the release notes now. End of day at the latest.

Cashe93 commented 2 years ago

Awesome, thanks!

MattReimer commented 2 years ago

I'm closing this with the release (which is out but yet to be approved by OSGEO). I'll reopen this issue if it isn't fixed.

MattReimer commented 2 years ago

@leallysmith and @Cashe93 0.6.0 is out (apparently my anouncement message didn't notify people. Sorry)

Please upgrade using the QGIS Plugins --> Manage and install plugins... menu.

FYI this patch took a while because of a backlog of other unrelated issues. If this issue still exists get in touch ASAP and the next one will be MUCH faster.

leallysmith commented 2 years ago

Thanks @MattReimer ! Now I've got an issue popping up where some projects open fine and others just give me a generic error that I've put in below. Some of the projects that won't open on my end have run fine on Cashe's system previously. QRAVEerror Could you direct me to where I find the QRAVE logs so I can find the problem and resolve it myself or if I can't, I can provide you with more detail about what is actually occurring.

MattReimer commented 2 years ago

Hey @leallysmith this is all good. I've changed the way we look for and handle errors to be a little more strict, a little more helpful and a lot more consistent.

Also if you can copy and paste the error text directly into github issues that helps us developers out quite a bit.

Getting to logs

First open the log messages panel. I like to get to it from the toolbar right-click menu:

Screen Shot 2021-09-07 at 1 56 36 PM

Then look for the QRave tab

Screen Shot 2021-09-07 at 1 58 24 PM