QRiS 0.1.5 Partial Test Drive

[joewheaton]

This started out as a full test of QRiS 0.1.5, but @philipbaileynar was quick to fix and release 0.1.6 so I will shift focus there. I will attempt to test all aspects of the tool. For things that work correctly, I have checked the box. For things where I find a bug or have a feature request or modification, I leave the task unchecked and if it is simple just describe it in task, and if more complicated I make an issue for it.

A bunch (not all) of the issues listed below (e.g. issues from #138 to #143 are in this video: https://youtu.be/9FF8SgMRwEM

Feature Tests & Requests

• [ ] Throughout tree, Add to Map should be greyed out if there are no contents within that type (e.g. If no Basemaps are added, the Add to Map should disabled).

Toolbar without Project

Tools Menu

• [x] #127

Help Menu

• [x] ? Help - Link works correctly to https://qris.riverscapes.net/
• [x] #124
• [x] #128

Project Basics

Top Menu

• [x] #131
• [x] Riverscapes Logo Button - Correctly brings up an empty QRiS Plugin panel
  • [x] #117
  • [ ] Change Riverscapes Logo Button needs tooltip from QRiS to Riverscape Studio Panel
• [x] New QRiS Project Button (+) - works as you would expect
  • [ ] #134
• [x] Open QRiS Project Button - works as you would expect when opening a existing project in a Blank qgz Untitled Project
  • [ ] #129
  • [ ] Testing behavior of Open QRiS Project when things open.

Tree Interaction

• Right Click Context Menu on Project

  • [x] Edit Project Properties - Works as you would expect and allows editing of Name and Description. Upon doing so it updated label in tree, and description is updated when you check it again by editing. Note that editing name does not change the Project Path
  • [ ] Is the Project Path dynamic or absolute? - It lists it as absolute
  • [x] #130
  • [x] #132
  • [x] #133

• I am not convinced that we have the right 'order' of the Project Tree yet. There is some logic in having DCEs first. But after that it seems a little haphazard. We need to think about this, but it is easy thing to change after more reps (without changing underlying data model) and even to allow different sort order of top level trees in a user settings menu that allows them to change display order and even labels if they must. I'd rather have a default and allow user customization on semantics issues that we can't agree on, as I think @nick4rivers and I will likely never agree on specifics, but I do think we agree on overall concepts and features.

Data Capture Events

Temporal framing (around 1:01 to 1:06 in https://youtu.be/9FF8SgMRwEM I talk about temporal sample frames. I ask for:

• [ ] Create Design: Add a group box around time components and label When? Temporal Representation of Sample Frame
• [ ] Create Design: It might be cleaner to do what GCD did and report back a text field representing the 'Timing', and a pop up for actual selection of dates.
• [ ] Create Design: Add a radio button to choose between Single Time Snapshot and Time Frame, with the later allowing selection of a Start Date and End Date.
• [ ] Create Design: We need to add concepts in their own group boxes.

Design

• [x] #143
• [x] Design seems to be working as expected from an editing perspective.
• [ ] Design is missing @nick4rivers helpful design table summaries and reports (we need to figure out where to expose these in QRiS tree (not Layer Tree). These were things like structure counts by complex or ZOI, areal statistics, crest lengths... lots of things.
• [ ] Design is missing the "default" specification (should be right click in Design Tree) of @nick4rivers concept of "Typical structure dimensions" and editing of "Structure Type" (library). We can discuss bringing those concepts all back in. They are useful, but we need to have our User/System options dialogs to do this.
• [ ] #76
• [ ] #145

As-Builts

Basemaps

• [x] I was able to 'Add a Basemap' of DEM from RS Context
• [ ] I did a whole bunch of testing of Basemaps from about 48 min to 1:00 (most worked https://youtu.be/9FF8SgMRwEM)
• [x] #147
• [ ] We need to have symbology recognition for basemaps based on
  • DEM
  • HAND
  • Aerial Photo (just uses default display)
  • Any specific basemap loaded from a riverscapes project won't need specification (it already knows) - see #52

Masks

• [x] Imported a StreamStats derived Catchment as a Mask - worked as expected
• [x] Geospatial Metrics - Mixed bag - some things worked some did not - This is all roughly minute 35 to 42 of video https://youtu.be/9FF8SgMRwEM
  • [ ] Geospatial Metrics ran inconsistently on same masks depending on layer state of tree.
  • [ ] Geospatial Metrics did not run for a regular mask.
  • [x] Could get Geospatial Metrics to run for both a imported and a new edited AOI mask.
  • [ ] Geospatial Metrics need to be able to control units and those should include full range that we used in GCD (including beer barrels)
  • [ ] Geospatial Metrics - Consider changing order of 'Value' and 'Units in return
  • [ ] Geospatial Metrics needs export feature to be plumbed
  • [ ] Geospatial Metrics should use the QML or symbology settings for feature to help it summarize and differentiate (e.g. if symbology is for perennial, connector and artificial path, it could have stats for each as well as total.
  • [ ] Geospatial Metrics is incorrectly summarizing the entire feature class regardless of what is being displayed (e.g. all the lengths instead of what is actually on)
  • [x] Geospatial Metrics is correctly only summarizing what is currently turned on or visible in the map.

Context

• [ ] #138
• [x] Ran StreamStats multiple times to get the watershed and subwatersheds for my basin of interest (without flow statistics) - worked as expected
  • [x] #139

Analyses

Scratch

• [x] #140
• [x] #141
• [x] Successfully deleted "empty" scratch space vector from project and map.
• [x] Successfully brought entire raster in with Import Existing Scratch Raster
  • [ ] Please change dialog name to Import Existing Raster (it is not already an "existing scratch raster", you are going to make it one)
  • [x] #142
  • [ ] Imported rasters may not be importing with CRS? Double check.

[joewheaton]

@philipbaileynar I think most of this is obsolete, but MUCH should be gone through carefully to convert incomplete tasks to issues if still relevant. Lets revisit together.