Closed mhallerud closed 4 years ago
wally-mac
commented
4 years ago @mhallerud I'm in favor of combing the tools into a folder structure and coding framework, so that there is one folder for all RCAT outputs and so that RCA uses the RVD output as an input, instead of recalculating RVD.
mhallerud
commented
4 years ago @wally-mac I have it restructured now so that it looks like this:
All RCA and RVD inputs are pulled into a single folder structure similar to BRAT now, and RCA takes RVD as input so that RVD isn't being calculated twice. This should also remove any possibility of differences between the RVD values used for each tool (i.e., as in #15)
wally-mac
commented
4 years ago @mhallerud why is Bankfull Channel part of this toolbox?
mhallerud
commented
4 years ago @wally-mac I'm not entirely sure why Bankfull Channel is included in here and in the Confinement Toolbox. Previously they were slightly different functions, but one didn't run. When I updated the toolboxes for PIBO, I combined all changes for Bankfull Channel so they're the exact same code now. Should I remove it from this toolbox?
wally-mac
commented
4 years ago I think so.
On Tue, Mar 3, 2020 at 1:20 PM Margaret Hallerud notifications@github.com wrote:
@wally-mac https://github.com/wally-mac I'm not entirely sure why Bankfull Channel is included in here and in the Confinement Toolbox. Previously they were slightly different functions, but one didn't run. When I updated the toolboxes for PIBO, I combined all changes for Bankfull Channel so they're the exact same code now. Should I remove it from this toolbox?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Riverscapes/RCAT/issues/18?email_source=notifications&email_token=AFHZAUQXKFZRC4UAJIPTIHLRFVRAJA5CNFSM4K5BIXAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENU74KI#issuecomment-594148905, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFHZAUVDBDRC24LKPPOWABDRFVRAJANCNFSM4K5BIXAA .
-- Sent from Gmail Mobile Sorry for typos and brevity courtesy of my phone.
jenna-walsh
commented
4 years ago A couple things on the updated RCA Project tool:
mhallerud
commented
4 years ago @jenna-walsh I think I took care of the first two issues. As far as the third error, I cannot replicate it on my machine- it copies over both dredge tailings and the LRP fine- so we will have to take a look at it together on your machine some time. For the time being, this issue can be bypassed by copying the needed shapefiles over into your inputs in the intended folder structure.
mhallerud
commented
4 years ago This problem has been fully addressed in RCAT Version 2.0.
@wally-mac, Jenna Walsh (from the USFS PIBO team) and I have been investigating RCAT outputs for the PIBO project and have noticed a few improvements that can be made to RCAT. One of these is the linearity of the RCAT toolbox. Currently, RCA and RVD are set up to run separately, even creating separate folder structures despite the fact that both tools use the exact same inputs. This structure is also inefficient because vegetation departure is calculated twice - once in RVD, and then again in RCA. The goal would be to combine the tools into a folder structure and coding framework, so that there is one folder for all RCAT outputs and so that RCA uses the RVD output as an input, instead of recalculating RVD. This would also make it much easier to create watershed-level outputs such as layer packages and summary tables if we wanted to go that route.
The only possible downside is that users wanting to run RCA but not RVD (which takes quite long to calculate conversion types) will have to wait a bit longer. However, I'm wondering if this won't be too big of a deal since most users are more than happy to get more information and this will be the easiest and most efficient way for them to get all of the RCAT outputs in one run.