search

Riverscapes / RaveAddIn

RAVE AddIn for ArcGIS
http://rave.riverscapes.xyz/
GNU General Public License v3.0
1 stars 3 forks source link

GUT Business Logic - plumb layer files #105

Closed joewheaton closed 3 years ago

joewheaton commented 3 years ago

@philipbaileynar wrote us nice Riverscape Projects for GUT and a version of GUT that exposes what is in those files. @wally-mac please have @Cashe93 or whomever use this ticket to tie the pull request to (re-assign from yourself to them). This is tied the Basecamp ToDo

wally-mac commented 3 years ago

@Cashe93 I've assigning this task to you. @tyler1218hatch please help Cashe on this as needed. Thanks!

philipbaileynar commented 3 years ago

I just released version 2.0.3 of RAVE that includes Cashe's pull request containing business logic and lots of layer files. @joewheaton described this as 95% of what's needed. Here's his video describing the outstanding items

https://youtu.be/-SU3FLcbzCk

wally-mac commented 3 years ago

@Cashe93 can you please address the outstanding items Philip points out in his video? Thanks for providing this Philip

Cashe93 commented 3 years ago

@philipbaileynar, do we still need to save layer files as version 10.4?

philipbaileynar commented 3 years ago

Good question... I am on 10.6.1 now. So technically you should choose nothing newer than 10.6.1 as the version. I think 10.4 will still work because all our existing symbology works for me.

What are the options newer than 10.4?

Cashe93 commented 3 years ago

Sounds good. The options newer than 10.4 are 10.5 and 10.6.

philipbaileynar commented 3 years ago

OK, go with 10.6 from now on then.

No reason to redo any of the existing layer files.

philipbaileynar commented 3 years ago

@Cashe93 please close this issue if the work is complete. I know 90% of the layers are how @joewheaton wants them, I'm just uncertain if we are all the way there?

Cashe93 commented 3 years ago

@philipbaileynar, I have a short list of changes that @joewheaton would like to be made. I don't think these will get it to 100% satisfaction but I'll close this after I make the changes and the pull request is reviewed.

Cashe93 commented 3 years ago

@philipbaileynar, I'm sorry this took so long for me to get to. I've just submitted a pull request/review on the changes.

philipbaileynar commented 3 years ago

Fixed as part of release 2.1.1