search

Riverscapes / RaveAddIn

RAVE AddIn for ArcGIS
http://rave.riverscapes.xyz/
GNU General Public License v3.0
1 stars 3 forks source link

Adds Basemaps for NWI data #134

Closed tyler1218hatch closed 2 years ago

tyler1218hatch commented 3 years ago

This was pretty quick, and all four maps seem to be displaying correctly. Fixes #132

joewheaton commented 3 years ago

@tyler1218hatch I am a little confused by this one. I appreciate you jumping on getting the additions in there. I think this stalled out for two reasons:

  1. You need to assign/request a reviewer beyond the assignee (assignee is gate keeper on pull requests); reviewer is someone who requested it or can sign off on it or something.
  2. Timing with QRAVE and WebRAVE development and getting lost in shuffle.

I'm going to post some questions and tasks over in #132 to get a proper steer from @MattReimer or @philipbaileynar and get this back on track. I'll also post a review here.

tyler1218hatch commented 3 years ago

@joewheaton Thanks for the feedback. These comments and the meeting on Friday helped me realize that my pull requests need a lot of improvement. I’ll make sure to follow all of the necessary guidelines in future pull requests.

I’ll also take a look at these again today and incorporate the changes you requested. Let me know if there’s anything else I should be doing differently.

joewheaton commented 3 years ago

Good stuff @tyler1218hatch. We're all getting there...

philipbaileynar commented 2 years ago

Closing this PR because its out of date. And also we have moved basemaps definitions to RiverscapesXML.