ArcRAVE enhancements now that we have QRAVE

[philipbaileynar]

Now that we have QRAVE we have some changes to make to ArcRAVE:

Mandatory

• [x] Enhance ArcRAVE to consistently use relative XPaths in business logic
• [x] Use QRAVE layer icons in tree - including different icons by geometry type
• [x] Implement the new project view XML
• [x] BaseMaps.xml has changed slightly (see https://github.com/Riverscapes/RiverscapesXML/pull/85). Just maps sure this loads. For now just filter out anything but type='wms'. I have a separate issue for implementing the other types #139

Optional

• [x] #162
• [ ] Explode basemaps into component layers (instead of one tree node per type) like QRAVE

Out of Scope

• [ ] Re-write layer symbology to parse QML and construct ESRI symbology on the fly.

[joewheaton]

@philipbaileynar on

Download business logic and layer files on the fly instead of shipping with the AddIn

Can we do this please (or just add the "Update Resources" button @MattReimer used in QRAVE? With all these folks ramping up to do business logic and symbology fixes, it would be nice for you not to have to issue a new release of ArcRAVE with every damn pull request to RiverscapesXML. Plus, it is a pain for users to uninstall AddIn and Re-install.

[philipbaileynar]

Totally agree.

Let us look into it. The big unknown here is safely calling over the internet from inside ArcGIS. @MattReimer and I developed some multi-threaded code recently for doing this. It worked perfectly from a Hello Word test app, but would not work from within ArcGIS. Perhaps because ArcGIS is a single threaded app? We are not sure.

We will look into it and use some of the unspent QRAVE budget on this task.

[philipbaileynar]

Closing this issue as all the important differences between QRAVE and ArcRAVE are now implemented in 3.0, specifically the automatic download of business logic and layer files.

The only real outstanding issue is the treatment of basemaps not being exploded into their constituent parts.