Riverscapes / RaveAddIn

RAVE AddIn for ArcGIS
http://rave.riverscapes.xyz/
GNU General Public License v3.0
1 stars 3 forks source link

Get Labels from *.lyr files to work. #36

Closed joewheaton closed 4 years ago

joewheaton commented 4 years ago

The Problem

In Number 11 & 12 of #33, we bring up this problem:

10. Unit ID label missing

I thought labels came over with UnitNum.lyr? This adds to map with right symbology, but the label customization are missing (just trying to show label for UnitID field number). https://github.com/Riverscapes/RaveAddIn/blob/master/RaveAddIn/XML/topo.xml#L11

image

@philipbaileynar says this is a new feature. Just flagging it here.

joewheaton commented 4 years ago

Confirming that this was not addressed in 1.1.0.

philipbaileynar commented 4 years ago

Confirmed. This didn't make it in.

joewheaton commented 4 years ago

@philipbaileynar can you give me an update on this one? It would be really helpful for a bunch of our RS projects.

philipbaileynar commented 4 years ago

@joewheaton can you please test this feature using release 1.1.10

Probably easiest to test using a local layer file in your AppData symbology folder that has labels.

Please close this issue if it works. Post comment/error/behaviour if it does not.

joewheaton commented 4 years ago

Actually, I turned them on in published version for Topo. It works... but other minor bug.

https://youtu.be/S35uLRtWzoE

philipbaileynar commented 4 years ago

Closing this issue because labels are working. The outstanding issues raised by @joewheaton relate to inconsistencies in topo project channel unit ShapeFiles; specifically whether they have grain size attributes. I will review the outstanding issues and ensure that those problems are captured in the appropriate places.