VBET Business Logic Round 2

Riverscapes / RaveAddIn

RAVE AddIn for ArcGIS

http://rave.riverscapes.xyz/

GNU General Public License v3.0

1 stars 3 forks source link

VBET Business Logic Round 2 #63

Closed joewheaton closed 3 years ago

joewheaton commented 4 years ago

The Problem

We need to update the VBET business logic to be more consistent with the Riverscape Context. Special care should be made to use symbology keys that are common and in Shared, and to use consistent labels. Namely:

[ ] Drainage Network should use same as Hydrography in RS_Context
[ ] Slope Raster should be same as Slope Analysis
[ ] HAND Raster is same but label needs updating
[ ] Intermediate Thresholds should all be hollow... maybe play with some different things.
[ ] VBET Network should be moved back to Drainage Network Inputs

This will be iterative. Try some things, post them here for me to give you feedback on and make as separate commits to a VBET-bl-2 branch you create.

Cashe93 commented 4 years ago

Hey @joewheaton, I've been looking into creating branches and working from those. I have made a VBET-bl-2 branch locally, but when I tried to publish the branch it's saying I don't have the right access to riverscapes/RaveAddIn. I could have sworn you guys had given me access. Any suggestions?

philipbaileynar commented 4 years ago

Let me try increasing your permissions

Cashe93 commented 4 years ago

Thanks @philipbaileynar. Let me know what I can/need to do on my end.

philipbaileynar commented 4 years ago

Please try again @Cashe93

Cashe93 commented 4 years ago

That seems to have worked. Thanks @philipbaileynar!

Cashe93 commented 4 years ago

@joewheaton could you elaborate a bit more on 'Drainage Network should use same as Hydrography in RS_Context'? Did you want the contents of VBETs Drainage Network to match the contents of Hydrography from RS Context? i.e. same shapefiles, labeling and symbology?

Cashe93 commented 4 years ago

@joewheaton I just submitted a pull request. I've placed the symbology layers for the intermediate thresholds in the VBET symbology folder (within the VBET-bl-2 branch).

joewheaton commented 4 years ago

Sorry for slow reply @Cashe93 ... been slammed.

@joewheaton could you elaborate a bit more on 'Drainage Network should use same as Hydrography in RS_Context'?

I just mean to copy the same business logic over. We have the same files for the network in both places, so might as well just bring in those business logic nodes under the Hydography: .

Did you want the contents of VBETs Drainage Network to match the contents of Hydrography from RS Context? i.e. same shapefiles, labeling and symbology?

Exactly. And those layer files can just be moved into Shared.

Cashe93 commented 4 years ago

Hey @joewheaton, how do I request a review on changes I've made to a branch with an existing pull request?

joewheaton commented 4 years ago

@joewheaton could you elaborate a bit more on 'Drainage Network should use same as Hydrography in RS_Context'? Did you want the contents of VBETs Drainage Network to match the contents of Hydrography from RS Context? i.e. same shapefiles, labeling and symbology?

Exactly. You should have same fcode so should be able to just copy business logic over from RS Context and just point to correct node.

joewheaton commented 3 years ago

I think (not sure) this is done? Please take a look @Cashe93

Cashe93 commented 3 years ago

Yes @joewheaton, it looks like this task was completed back in June.