search

Riverscapes / RaveAddIn

RAVE AddIn for ArcGIS
http://rave.riverscapes.xyz/
GNU General Public License v3.0
1 stars 3 forks source link

Update business logic for most rasters to be transparent #66

Closed joewheaton closed 4 years ago

joewheaton commented 4 years ago

I'm assigning to @tyler1218hatch and @Cashe93. You two can agree on who will update what on what branches. Other than hillshades, most (not all) of our rasters should probably default to be transparent (~ transparency="40"). See @philipbaileynar example in https://github.com/Riverscapes/RaveAddIn/blob/master/RaveAddIn/XML/topo.xml#L116.

Please update:

tyler1218hatch commented 4 years ago

Here's the branch I'm using for this issue.

@Cashe93 I'll do BRAT, VBET, and Hydro if you do Topo and rsContext. @joewheaton What kind of rasters won't be transparent? Would that be non topographical ones like vegetation data?

Cashe93 commented 4 years ago

Sounds good @tyler1218hatch. Just to confirm, is it alright to work from the same branch, or do I need to create a separate one?

tyler1218hatch commented 4 years ago

I think we should work on the branch together. That should be fine since we're not working on conflicting files. Just let me know when you're finished, then we can do a pull request.

Cashe93 commented 4 years ago

@tyler1218hatch, how do I access this branch in git Desktop? Should it be an option automatically under the 'Current branch' tab or do I need to pull it from this repository somehow?

tyler1218hatch commented 4 years ago

It should just be an option under all of the available branches. Try fetching the origin or closing and reopening github desktop if none of that works.

Cashe93 commented 4 years ago

@tyler1218hatch it just popped up. Thanks!

Cashe93 commented 4 years ago

@tyler1218hatch I just committed the changes for both rs_context and topo. Can you see the commits on your end? It's saying I don't have write access so I'm curious to see if it's only committing changes locally.

tyler1218hatch commented 4 years ago

I don't see them. I'll try to figure this out soon.

Cashe93 commented 4 years ago

Sounds good @tyler1218hatch. I've also brought it to the attention of both Joe and Philip so hopefully, it'll be resolved soon.

tyler1218hatch commented 4 years ago

From what I can tell, only the master branch has restrictions. So I'm not sure why this one isn't letting you push to it. If you want to send a video of the issue that could help, or we can just wait to hear back from Phillip or Joe.

Cashe93 commented 4 years ago

Hey @tyler1218hatch, it appears that Philip has resolved the issue. Are you now able to see those commits on your end?

tyler1218hatch commented 4 years ago

Yes, I can see them! I’ll finish this up and do a pull request early tomorrow.

joewheaton commented 4 years ago

In response to:

@joewheaton What kind of rasters won't be transparent? Would that be non topographical ones like vegetation data?

Actually, I typically turn on the veg with transparency too (the context of hillshade is really good)... hmmm let me think. Maybe just make them all and if @CHafen or I figure something out, we'll go from there.

As best I can tell, you guys sorted out other stuff? REmember, if you want us to get the notifications when you mention us use the @philipbaileynar instead of just Philip if you want him to see it.