Riverscapes / RiverscapesXML

Serving location for Riverscapes XSD validation schemas
http://xml.riverscapes.xyz
4 stars 1 forks source link

Ecoregions 1- 4 are NOT symbolized at all or correctly (use EPAs legends to get colors and labels). #558

Open joewheaton opened 1 year ago

joewheaton commented 1 year ago

See https://youtu.be/Ze60sYAgu9s?t=2133

Fix with Labels (using Karla) and Symbology for

To-Do

wally-mac commented 1 year ago

@leallysmith I'm assigning this to you. Please delegate as needed. Thanks.

Cashe93 commented 1 year ago

@joewheaton, The issue with the Ecoregion 3 layer is that the attribute values from the RSContext layer are inconsistent with the EPA layer (luckily, this only appears to be an issue with L3). The attribute the symbology is referencing for L3 should start with a three-decimal code (e.g. 2.9.3), but for whatever reason, the level 3 ecoregion attribute that is within RSContext projects is just a two-digit integer.

image

The only solution I can think of is to download the full North American layer and manually curate the symbology using an attribute that only references the name and not the code. This wouldn't take too much time if you were ok with an approximate similarity to the EPA symbology. If you wanted the symbology to match the EPAs exactly, that will take quite a bit longer given the number of classes. Thoughts? I'm also open to any ideas other @Riverscapes/riverscape-project-curators might have to get the current symbology to work.

joewheaton commented 1 year ago

Thank you so much @Cashe93 for the explanation. @philipbaileynar what do you think. Add these to the National dataset?

jtgilbert commented 1 year ago

This is already pulled from the National dataset. I think it's just a data consistency issue.

joewheaton commented 1 year ago

I'm not following on your suggestion? We need to mitigate against know inconsistency if we can.

shelbysawyer commented 1 year ago

I was working in this RS Context project in QRV and noticed that Level 1, 2, and 4 Ecoregions show up and are symbolized, but Level 3 Ecoregions do not. It also looks like the labels are displaying twice for Level 1 Ecoregions:

rsc

Cashe93 commented 1 year ago

Just circling back on this. @shelbysawyer thanks for the notes; the level 3 ecoregion issue has been discussed above. It looks like the redundant labels are just a result of the layer being a multipart feature; each feature is labeled once but there are multiple features with the same name.

@joewheaton and @jtgilbert how would you like me to proceed with the level 3 symbology? Also, level 4 ecoregions have nearly 1000 categories; symbology has been applied for Q and Arc but to manually do this in Mapbox is going to be pretty tedious and time-consuming. Do you think this is worth muscling through, or should we explore alternative options? @MattReimer, any ideas on how to streamline this?

MattReimer commented 1 year ago

As for the duplicated label you're right that it's probably due to the multipart feature. There's no hard solution to this that I'm aware of but you might be able to dial that in (in the web anyway) using features like symbol spacing:

As for the 1000 category feature:

If you symbolize one category the way you like it then it might be possible to write a python script to convert from the qml. We do something similar for the EVT rasters HERE but the idea is the same. You just need to output a JSON file instead of a CSV file.

CHafen commented 1 year ago

Just bring this back up @Cashe93 @jtgilbert @joewheaton as level 3 ecoregions are not symbolized yet for web.

@joewheaton and @jtgilbert how would you like me to proceed with the level 3 symbology? Also, level 4 ecoregions have nearly 1000 categories; symbology has been applied for Q and Arc but to manually do this in Mapbox is going to be pretty tedious and time-consuming. Do you think this is worth muscling through, or should we explore alternative options? @MattReimer, any ideas on how to streamline this?

joewheaton commented 1 year ago

I can't remember what the problem was? @Cashe93 do you? I think we figured out why it was not displaying properly, but maybe not a solution?

joewheaton commented 1 year ago

Also @CHafen did you see the new webRV stuff that @MattReimer added for vector layer editing in browser? It is really nice for testing and customizing what you want.

Cashe93 commented 1 year ago

@joewheaton, yeah we figured out why it wasn't displaying properly, but still haven't pinned down a solution. See here (or above) for the comment laying out the issue.

joewheaton commented 1 year ago

@CHafen, can you please schedule a time to meet with @Cashe93 and maybe he can walk you through the manual fix proposed. If necessary, bring in @Jdgilby if any additional cleaning of that dataset is needed.

If this proves unfruitful, then lets just remove the Level III from Business Logic.