DoD Stats in GCD Projects have inconsistent units

[philipbaileynar]

Will Conley provided a GCD project where the original data are all in imperial units but the DoD stats written to the GCD project file uses inconsistent units.

Here's the top of the GCD project file:

<Project>
  <Name>HaulRd_2009_1pt5ft_CrossCompare</Name>
  <DateTimeCreated>2019-05-18T19:10:01.6619615+12:00</DateTimeCreated>
  <GCDVersion>7.4.1.0</GCDVersion>
  <Description>Comparison of 1.5 ft DEMs derived from same LAS points using different DEM construction methods</Description>
  <Units>
    <Horizontal>UsSurveyFoot</Horizontal>
    <Vertical>Foot</Vertical>
    <Area>SquareFoot</Area>
    <Volume>CubicYard</Volume>
  </Units>
...

And then lower down here is part of just one of several DoD records. The area values are written using square feet but the volumes are written in metres cubed.

 <DoDs>
    <DoD>
      <Name>BE_2009_brkln_1pt5ft_bin_linear_BE_2009_brkln_1pt5ft_bin_NatN MinLoD at 0.10ft</Name>
      <Folder>Analyses\CD\DoD0001</Folder>
      <NewSurface type="dem">BE_2009_brkln_1pt5ft_bin_linear</NewSurface>
      <OldSurface type="dem">BE_2009_brkln_1pt5ft_bin_NatN</OldSurface>
      <RawDoD>Analyses\CD\DoD0001\raw.tif</RawDoD>
      <ThrDoD>Analyses\CD\DoD0001\thresh.tif</ThrDoD>
      <ThrErr>Analyses\CD\DoD0001\threrr.tif</ThrErr>
      <RawHistogram>Analyses\CD\DoD0001\raw.csv</RawHistogram>
      <ThrHistogram>Analyses\CD\DoD0001\thresh.csv</ThrHistogram>
      <SummaryXML>Analyses\CD\DoD0001\summary.xml</SummaryXML>
      <Threshold>0.10</Threshold>
      <Statistics>
        <Erosion>
          <Raw>
            <Area>14502585.504440276</Area>
            <Volume>1036.9819861060819</Volume>
          </Raw>
          <Thresholded>
            <Area>2804835.4269655487</Area>
            <Volume>643.75640941857591</Volume>
  ...

Solution

All values written to the GCD project file should be consistent, and probably using the project linear units.

Be careful fixing this issue and consider the impact to folks with legacy GCD projects.

[philipbaileynar]

Fixed via #357