search

Riverscapes / pyBRAT

pyBRAT - Beaver Restoration Assessment Tool (Python)
http://brat.riverscapes.xyz
GNU General Public License v3.0
10 stars 10 forks source link

Including ditches in canals shapefile + merging with perennial (Internal) #274

Closed bangen closed 5 years ago

bangen commented 5 years ago

@wally-mac @mhallerud @banderson1618

Based on our conversation earlier today I modified Maggie's 'ExtractCanals_Batch' script and also put together a 'MergePerennialCanals_Batch' script. I tested on a few basins. If you want the nitty, gritty details you can check out this short video.

The one thing I'd like feedback on is a call I made to just output a single 'NHDCanals' shapefile (that includes the named ditches) rather than separate canals and ditches shapefiles. I think it's a little cleaner to have a single shapefile, but if anyone wants to them separated out let me know and I can make the change.

bangen commented 5 years ago

More or less just put this up for documentation purposes so I'm going to go ahead and close unless an issue arises.

wally-mac commented 5 years ago

How about we can it 'NHD_Canals_Ditches" I think this better describes what it contains.

On Mon, Apr 1, 2019 at 3:44 PM bangen notifications@github.com wrote:

@wally-mac https://github.com/wally-mac @mhallerud https://github.com/mhallerud @banderson1618 https://github.com/banderson1618

Based on our conversation earlier today I modified Maggie's 'ExtractCanals_Batch' script and also put together a 'MergePerennialCanals_Batch' script. I tested on a few basins. If you want the nitty, gritty details you can check out this short video https://youtu.be/RtJUCGtjDBQ.

The one thing I'd like feedback on is a call I made to just output a single 'NHDCanals' shapefile (that includes the named ditches) rather than separate canals and ditches shapefiles. I think it's a little cleaner to have a single shapefile, but if anyone wants to them separated out let me know and I can make the change.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Riverscapes/pyBRAT/issues/274, or mute the thread https://github.com/notifications/unsubscribe-auth/AU-QUuehPiG6j6KGf1-bgeOlMmVD57OHks5vcn3TgaJpZM4cWs_q .

-- Wally Macfarlane 435.512.1839

bangen commented 5 years ago

Per feedback from @wally-mac I changed the 'NHDCanals' name to 'NHDCanalsDitches'. So @mhallerud we'll want to make sure we're pointing to that shapefile in the batch BRAT runs and not the old 'NHDCanals' shp. Probably best to delete that one from the HUC8 folders, but that can just be a rainy day task.