Closed bangen closed 6 years ago
Cross-referencing issue #76
@bangen This sound good, I will pick this stuff up tomorrow
@webernick79 and @bangen I talked to Joe this morning and he wants/needs the Survey123 Form updated as Sara indicates above ASAP. I think we needs them for the Hailey workshop on June 20th. Also, Sara have you are can you please update the associated paper forms? Let's make these a priority. Thanks a ton!
@wally-mac and @bangen , sorry this got away from me, I'm on it today.
n
@wally-mac I'll start working on the paper form updates
Hey @bangen - so it's this sheet, and the CombFIS RulesWithTrumps tab:
Form and logic should match that correct? and incorporate the updates in column "Capacity Changes"
Hey @bangen and @wally-mac For your trip to CA, is this map the actual data that needs to be kept and analyzed. Collected using the Advanced BRAT Form: http://nick-weber.maps.arcgis.com/home/webmap/viewer.html?webmap=e7e97066319443a19915cb7c913d0820
Was there anything else of importance collected using the other forms?
YES! All data that was collect on all forms is real and needs to be saved. Thanks for asking!
Hey @webernick79 to make things a little clearer I revised the Google spreadsheet I shared so it just has the 2 tabs: 1 for the combinedFIS and one for the vegFIS. I also added the paper field form number since it's no always the same as what we have in the python code. Thought this would make it easier for you to make your edits.
Right @bangen I'm just testing out the logic in the survey, I'll send to you to have a look at in a bit.
Hey @wally-mac and @bangen , looks like things are straightened out with the capacity logic. Thanks for the updates Sara.
Here is the latest BRAT Advanced App for Survey123 Sara, do you wanna give it a look and let me know if things need changing.
Also, here's a download of the Truckee Validation Data It would also be good to give this a look let me know if anything about the attributes looks wonky or difficult to analyze
Thanks,
Also, @bangen and @wally-mac is anyone going to be using these forms anytime soon. When people use this data it will be best to create a new instance of the survey so that the data flows into its own layer. Will save us a lot of headache downstream.
@bangen Here are the tables I used to build the logic expressions:
@chadFHC do you know how to "create a new instance of the survey so that the data flows into its own layer" as described by @webernick79. This something that we'll want to do for the Idaho BRAT data collection that is going to start up this week and additional California data collection in the coming months.
@webernick79 Nick, what exactly do you mean by "create a new instance of the survey so that the data flows into its own layer?" Do you mean just make "clones" of the survey so that each survey has its own results?
@wally-mac @joewheaton I put together new field forms which can be found on Box here. Joe, with the complete rule table for the combined FIS the tables no longer fit nicely on a single page. Upside is they are a little more legible.
Thanks Sara! I'm going to have @kbartelt (Karen) read these over.
I read these over and everything looked good to me. The forms were easy to understand and use. I did change a small typo.
Excellent. These should be ready to be used to update the Survey123 form, @webernick79.
@wally-mac brought up the following issue with the cIS Survey123 form:
The reach slope component of the cIS form needs modification see video: https://youtu.be/1S2zbsLZzo8
@webernick79 please update the Survey123 slope drop down options as follows:
For future reference, the above discrete categories were pulled from the fuzzy sets using the 4th vertex of each membership function. Fuzzy MF values (in m/m):
slope['flat'] = fuzz.trapmf(slope.universe, [0, 0, 0.0002, 0.005])
slope['can'] = fuzz.trapmf(slope.universe, [0.0002, 0.005, 0.12, 0.15])
slope['probably'] = fuzz.trapmf(slope.universe, [0.12, 0.15, 0.17, 0.23])
slope['cannot'] = fuzz.trapmf(slope.universe, [0.17, 0.23, 1, 1])
@webernick79 When @wally-mac, @joewheaton and I were out in the field we realized some of the rules weren't behaving as intended. We did some digging and found that some of the rules were missing from the paper form (and likely the Survey123 app). We also made some tweaks to the capacity output category for several of the rules in the combined capacity model.
Long story short, these changes need to be integrated into Survey123. I shared a Google spreadsheet with you. The sheet you'll want to reference is 'CombFIS-RulesWithTrumps'. The rose colored rows are the rules where we need the output capacity category changed. The new output category is in the 'Capacity Changes' column. Joe's field form table was cut off at 'pyBRAT Rule #' 52. Not sure if this is what you were referencing to build the Survey123 logic. If so, the missing rules will need to be coded in.
Lastly, Wally mentioned that the Survey123 conditional statements for the rules are pretty unwieldy. Once you've re-coded things feel free to send me the code block to have a second set of eyes on it.