Jekyll Topbar menus to be centralized

Riverscapes / riverscapes-jekyll-theme

Gem-based GHPages theme that all docs will consume from

https://riverscapes.github.io/riverscapes-jekyll-theme/

MIT License

0 stars 2 forks source link

Jekyll Topbar menus to be centralized #12

Open MattReimer opened 4 years ago

MattReimer commented 4 years ago

Right now the Topbarmenu needs to be defined in each site's _config.yml

@joewheaton pointed this out: https://github.com/Riverscapes/fmLTPBR/issues/8#issuecomment-624289205

So I'm going to make the Topbar non-optional and non-customizable for sub-sites. It's just too complicated to handle overrides

Changes that will need to be made to individual sites:

Remove the topmenu yaml item and all it's children from each site's _config.yml. This isn't totally necessary since I'm teaching the root theme to just ignore it but it will clean thigns up AND force a refresh of the site.

MattReimer commented 4 years ago

Note: this needs to happen before #4 can be fixed

MattReimer commented 4 years ago

I can confirm that the _config.yml file from the parent is getting into the build. Not sure why the topbar variable isn't available in the child.

joewheaton commented 3 years ago

@MattReimer you will see #21, which is related but separate. Is this issue (12) one that is already resolved?

MattReimer commented 3 years ago

Nope. All of these are still open. I haven't done a jekyll pass in a while. Probably something to do soon-ish

joewheaton commented 3 years ago

Thanks! As you can see, I am obviously in a mode of looking at our many loose ends and trying to queue up how we clean up our appearances as more funding is secured and more eyes are going to be on our stuff. Thanks!