search

Riverscapes / riverscapes-tools

Open-source Python 3.0 tools for the Riverscapes organization
https://tools.riverscapes.net/
GNU General Public License v3.0
11 stars 8 forks source link

NHD connectors increasing confinement #313

Closed lauren-herbine closed 8 months ago

lauren-herbine commented 3 years ago

Not sure if this is an already known issue, but thought I'd note here for record keeping.

Confining polygons (and therefore raw confinement, confinement ratio, and constriction ratio) are not calculating correctly around the NHD connecting flowlines within reservoirs/lakes. Recorded a lil video here

image

lauren-herbine commented 3 years ago

Looks like this is similar to #312

joewheaton commented 3 years ago

So @lauren-herbine, @KellyMWhitehead both VBET and confinement right now need some actual thinking on what the inputs should be. Inputs to Confinement are generally wrong... need geomorphology eyes. One thing to be careful with is that confinement is a "channel network" calculation and tool that requires a valley bottom riverscape as an input to calculate it. By contrast, the VBET is actually a riverscape network tool. Many of the problems in confinement right now, are because a) we don't have VBET yet doing what we want, b) we're not using the "right" vbet output, and c) we're not filtering this down to what channel(s) network we want it calculated for.

philipbaileynar commented 8 months ago

VBET and confinement have been rewritten since this ticket.