Get Confinement Working With Latest VBET and Channel Area Outputs

Riverscapes / riverscapes-tools

Open-source Python 3.0 tools for the Riverscapes organization

https://tools.riverscapes.net/

GNU General Public License v3.0

11 stars 11 forks source link

Get Confinement Working With Latest VBET and Channel Area Outputs #408

Closed philipbaileynar closed 2 months ago

philipbaileynar commented 3 years ago

Now that VBET is stable it's time to revisit confinement.

[x] Refactor confinement to take the channel area tool output layer (instead of buffering polylines inside confinement itself)
[x] Refactor confinement to take VBET68 layer (and works with multiple VBET polygons)
[x] Confirm or implement the buffering of the channel area layer. This should be 1.5x the raster cell resolution, but given that confinement does not use any rasters, this value should be a command line parameter (i.1. 15m).
[ ] Run confinement on a single HUC to prove it runs, and provide a quick review before we run it more broadly.

KellyMWhitehead commented 3 years ago

@philipbaileynar, @joewheaton, @lauren-herbine: Here are the projects that have completed the updated confinement tool: 07020005 05140201 05040003 08010100 07050002 05010003 07080105 06010207 10270101

Note that confinement is calculated along the level path, which is much longer than we were previously using. There is a separate layer (confiment_ratio_segmented) that calculates confinement on the 300m segmented flowlines that were previously used, however this is not exposed in the business logic.

joewheaton commented 3 years ago

Thanks @KellyMWhitehead. @lauren-herbine please download and have a look at these. I have just downloaded and we'll dig in. There are some bigger segmentation issues we're going to have to deal with. Lets not forget that Gary O'Brian and I did a big sensitivity analysis of confinement on segmentation length. 500 m is what we came up with ;). I will take a look and see if I can't figure out what's going on/wrong.

lauren-herbine commented 3 years ago

@KellyMWhitehead I am noticing that not all flowlines have confinement calculated for them (specifically mainstem Mississippi). Do you have any ideas as to why this might be happening? I looked at 08010100

See video:

Edit: also happening in other HUCs (here is 10270101):

blue drawn line is a flowline but does not have confinement calculated for it. Could this have to do with FCode selection? A quick perusal doesn't point to this... the channels we are missing are main channels

philipbaileynar commented 2 months ago

Super old issue that refers to Kelly's initial version of a Riverscapes compliant version of confinement. Now we have Jordan's new implement that is a different model. Closing because it refers to a deprecated model.